Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] In a concurrency scenario, after a tablet is deleted, its corresponding data directory still exists. #50382

Merged
merged 4 commits into from
Sep 14, 2024
Merged

[BugFix] In a concurrency scenario, after a tablet is deleted, its corresponding data directory still exists. #50382

merged 4 commits into from
Sep 14, 2024

Conversation

zhangheihei
Copy link
Contributor

@zhangheihei zhangheihei commented Aug 28, 2024 •
edited by trueeyu
Loading

Why I'm doing:

What I'm doing:

Fixes #50383

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@zhangheihei zhangheihei requested a review from a team as a code owner August 28, 2024 17:30
@zhangheihei
[BugFix] In a concurrency scenario, after a tablet is deleted, its co…
a0e2ec5 
…rresponding data directory still exists.

Signed-off-by: edwinhzhang <[email protected]>
@zhangheihei zhangheihei force-pushed the bugfix-datadir-cannot-delete branch from 1be8c0b to a0e2ec5 Compare August 28, 2024 17:39
@zhangheihei zhangheihei force-pushed the bugfix-datadir-cannot-delete branch 3 times, most recently from 44b900a to 3054082 Compare August 29, 2024 03:22
@zhangheihei
fix clang-format
0f29581 
Signed-off-by: edwinhzhang <[email protected]>
@zhangheihei zhangheihei force-pushed the bugfix-datadir-cannot-delete branch from 3054082 to 0f29581 Compare August 29, 2024 04:01
@zhangheihei
fix clang tidy
d892f84 
Signed-off-by: edwinhzhang <[email protected]>
@zhangheihei zhangheihei force-pushed the bugfix-datadir-cannot-delete branch from 93bc12c to d892f84 Compare August 29, 2024 06:09
meegoo
meegoo previously approved these changes Sep 6, 2024
View reviewed changes
@wyb wyb requested a review from sevev September 6, 2024 11:19
@zhangheihei zhangheihei force-pushed the bugfix-datadir-cannot-delete branch from 01f0429 to da17f57 Compare September 9, 2024 16:44
@zhangheihei
optimize deque to map
eaca6b9 
Signed-off-by: edwinhzhang <[email protected]>
@zhangheihei zhangheihei force-pushed the bugfix-datadir-cannot-delete branch from da17f57 to eaca6b9 Compare September 10, 2024 02:13
@github-actions GitHub Actions
Copy link

[Java-Extensions Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

❌ fail : 47 / 63 (74.60%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 be/src/storage/tablet_manager.cpp 47 63 74.60% [1021, 1022, 1023, 1033, 1034, 1035, 1038, 1039, 1040, 1044, 1045, 1050, 1051, 1053, 1054, 1055]

@zhangheihei zhangheihei requested review from meegoo and wyb September 10, 2024 08:07
@andyziye andyziye merged commit 5428afe into StarRocks:main Sep 14, 2024
48 of 49 checks passed
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.3

@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.2

@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.1

@github-actions github-actions bot removed the 3.1 label Sep 14, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 14, 2024 •
edited
Loading

backport branch-3.3

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 14, 2024 •
edited
Loading

backport branch-3.2

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 14, 2024 •
edited
Loading

backport branch-3.1

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Sep 14, 2024
@zhangheihei @mergify
[BugFix] In a concurrency scenario, after a tablet is deleted, its co…
0f8fd28 
…rresponding data directory still exists. (#50382)

Signed-off-by: edwinhzhang <[email protected]>
(cherry picked from commit 5428afe)
@mergify mergify bot mentioned this pull request Sep 14, 2024
Merged
42 tasks
mergify bot pushed a commit that referenced this pull request Sep 14, 2024
@zhangheihei @mergify
[BugFix] In a concurrency scenario, after a tablet is deleted, its co…
45aff35 
…rresponding data directory still exists. (#50382)

Signed-off-by: edwinhzhang <[email protected]>
(cherry picked from commit 5428afe)
@mergify mergify bot mentioned this pull request Sep 14, 2024
Merged
42 tasks
mergify bot pushed a commit that referenced this pull request Sep 14, 2024
@zhangheihei @mergify
[BugFix] In a concurrency scenario, after a tablet is deleted, its co…
a672604 
…rresponding data directory still exists. (#50382)

Signed-off-by: edwinhzhang <[email protected]>
(cherry picked from commit 5428afe)

# Conflicts:
#	be/src/storage/tablet_manager.cpp
#	be/src/storage/tablet_manager.h
@mergify mergify bot mentioned this pull request Sep 14, 2024
Closed
42 tasks
wanpengfei-git pushed a commit that referenced this pull request Sep 18, 2024
@mergify @zhangheihei
[BugFix] In a concurrency scenario, after a tablet is deleted, its co…
67a12c7 
…rresponding data directory still exists. (backport #50382) (#51051)

Co-authored-by: zhanghe <[email protected]>
wanpengfei-git pushed a commit that referenced this pull request Sep 18, 2024
@mergify @zhangheihei
[BugFix] In a concurrency scenario, after a tablet is deleted, its co…
90afd22 
…rresponding data directory still exists. (backport #50382) (#51052)

Co-authored-by: zhanghe <[email protected]>
renzhimin7 pushed a commit to renzhimin7/starrocks that referenced this pull request Nov 7, 2024
@zhangheihei @renzhimin7
[BugFix] In a concurrency scenario, after a tablet is deleted, its co…
bc5c0c2 
…rresponding data directory still exists. (StarRocks#50382)

Signed-off-by: edwinhzhang <[email protected]>
Signed-off-by: zhiminr.ren <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@starrocks-cr starrocks-cr[bot] starrocks-cr[bot] left review comments

@sevev sevev sevev approved these changes

@wyb wyb wyb approved these changes

@meegoo meegoo Awaiting requested review from meegoo

Assignees

@zhangheihei zhangheihei

Labels
3.2-merged 3.2 3.3-merged 3.3 behavior_changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

After tablet is deleted, its corresponding data directory still exists
5 participants
@zhangheihei @wyb @meegoo @sevev @andyziye