Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] fix MetdataCache concurrency issue #52968

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

luohaha
Copy link
Contributor

@luohaha luohaha commented Nov 18, 2024

Why I'm doing:

In previous PR, we introduced MetadataCache to achieve LRU strategy for rowset metadata memory manage, and when rowset been evict, then we will call this function:

void MetadataCache::_cache_value_deleter(const CacheKey& /*key*/, void* value) {
    reinterpret_cast<Rowset*>(value)->close();
}

to close rowset and release metadata memory.

But in some case, this rowset which pointer point to could has been destroy, but _cache_value_deleter doesn't know that and will still keep calling close(), and it will lead to concurrency issue.

What I'm doing:

This pull request includes several changes to the MetadataCache class and related functionality in the rowset module. The main goals are to improve memory management by using std::weak_ptr for cached rowsets and to rename the warmup_rowset method to refresh_rowset for clarity. Additionally, a new concurrency test is added to ensure thread safety.

Memory management improvements:

Method renaming for clarity:

New test for concurrency:

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@luohaha luohaha requested a review from a team as a code owner November 18, 2024 06:13
@luohaha luohaha requested review from kevincai and wyb November 18, 2024 06:32
Copy link

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[FE Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[BE Incremental Coverage Report]

pass : 10 / 10 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 be/src/storage/rowset/rowset.cpp 1 1 100.00% []
🔵 be/src/storage/rowset/metadata_cache.cpp 9 9 100.00% []

@wyb wyb merged commit 4bb449f into StarRocks:main Nov 19, 2024
42 checks passed
Copy link

@Mergifyio backport branch-3.3

@github-actions github-actions bot removed the 3.3 label Nov 19, 2024
Copy link

@Mergifyio backport branch-3.2

@github-actions github-actions bot removed the 3.2 label Nov 19, 2024
Copy link
Contributor

mergify bot commented Nov 19, 2024

backport branch-3.3

✅ Backports have been created

Copy link
Contributor

mergify bot commented Nov 19, 2024

backport branch-3.2

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Nov 19, 2024
Signed-off-by: luohaha <[email protected]>
(cherry picked from commit 4bb449f)
mergify bot pushed a commit that referenced this pull request Nov 19, 2024
Signed-off-by: luohaha <[email protected]>
(cherry picked from commit 4bb449f)
wanpengfei-git pushed a commit that referenced this pull request Nov 19, 2024
wanpengfei-git pushed a commit that referenced this pull request Nov 19, 2024
Smith-Cruise pushed a commit to Smith-Cruise/starrocks that referenced this pull request Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants