Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] Fix retry upload failure when backup files using HDFS filesystem interface #53679

Merged
merged 3 commits into from
Dec 27, 2024
Merged

[BugFix] Fix retry upload failure when backup files using HDFS filesystem interface #53679

merged 3 commits into from
Dec 27, 2024

Conversation

srlch
Copy link
Contributor

@srlch srlch commented Dec 6, 2024 •
edited
Loading

Why I'm doing:

HDFS filesystem interface does not support file mode with CREATE_OR_OPEN_WITH_TRUNCATE. If we want to new writable file but it has already existed, it will fail in this case. It means that it is impossible to retry upload in many cases in backup process.

What I'm doing:

Use O_WRONLY flag for hdfsOpenFile which implies O_TRUNCAT.

Fixes #53631

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.4
    • 3.3
    • 3.2
    • 3.1
    • 3.0

@srlch srlch requested review from a team as code owners December 6, 2024 09:09
@mergify mergify bot assigned srlch Dec 6, 2024
kevincai
kevincai reviewed Dec 7, 2024
View reviewed changes
be/src/fs/hdfs/fs_hdfs.cpp Outdated Show resolved Hide resolved
@github-actions github-actions bot removed the 3.2 label Dec 26, 2024
@srlch srlch force-pushed the bufix_retry_upload branch from f1a5c16 to ff83835 Compare December 26, 2024 09:13
srlch added 2 commits December 26, 2024 17:39
@srlch
fix
76081cd 
Signed-off-by: srlch <[email protected]>
@srlch
fix
a6fb8e8 
Signed-off-by: srlch <[email protected]>
@github-actions GitHub Actions
Copy link

[Java-Extensions Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

✅ pass : 2 / 2 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 be/src/fs/hdfs/fs_hdfs.cpp 2 2 100.00% []

@kevincai kevincai enabled auto-merge (squash) December 27, 2024 02:18
@kevincai kevincai merged commit 2d76f88 into StarRocks:main Dec 27, 2024
47 checks passed
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.4

@github-actions github-actions bot removed the 3.4 label Dec 27, 2024
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.3

@github-actions github-actions bot removed the 3.3 label Dec 27, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 27, 2024 •
edited
Loading

backport branch-3.4

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 27, 2024 •
edited
Loading

backport branch-3.3

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Dec 27, 2024
@srlch @mergify
[BugFix] Fix retry upload failure when backup files using HDFS filesy…
ec9ad1d 
…stem interface (#53679)

Signed-off-by: srlch <[email protected]>
(cherry picked from commit 2d76f88)
@mergify mergify bot mentioned this pull request Dec 27, 2024
Merged
18 tasks
mergify bot pushed a commit that referenced this pull request Dec 27, 2024
@srlch @mergify
[BugFix] Fix retry upload failure when backup files using HDFS filesy…
433ccc6 
…stem interface (#53679)

Signed-off-by: srlch <[email protected]>
(cherry picked from commit 2d76f88)
@mergify mergify bot mentioned this pull request Dec 27, 2024
Merged
18 tasks
@srlch
Copy link
Contributor Author

srlch commented Dec 27, 2024

https://github.com/Mergifyio backport branch-3.2

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 27, 2024 •
edited
Loading

backport branch-3.2

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Dec 27, 2024
@srlch @mergify
[BugFix] Fix retry upload failure when backup files using HDFS filesy…
7ccfa6d 
…stem interface (#53679)

Signed-off-by: srlch <[email protected]>
(cherry picked from commit 2d76f88)

# Conflicts:
#	be/src/fs/hdfs/fs_hdfs.cpp
@mergify mergify bot mentioned this pull request Dec 27, 2024
Closed
18 tasks
wanpengfei-git pushed a commit that referenced this pull request Dec 27, 2024
@mergify @srlch
[BugFix] Fix retry upload failure when backup files using HDFS filesy…
1b435c9 
…stem interface (backport #53679) (#54438)

Co-authored-by: srlch <[email protected]>
wanpengfei-git pushed a commit that referenced this pull request Dec 27, 2024
@mergify @srlch
[BugFix] Fix retry upload failure when backup files using HDFS filesy…
77bd201 
…stem interface (backport #53679) (#54439)

Co-authored-by: srlch <[email protected]>
srlch added a commit to srlch/starrocks that referenced this pull request Dec 27, 2024
@srlch
[BugFix] Fix retry upload failure when backup files using HDFS filesy…
bfcc40f 
…stem interface (StarRocks#53679)

Signed-off-by: srlch <[email protected]>
kevincai pushed a commit that referenced this pull request Dec 27, 2024
@srlch
[BugFix] Fix retry upload failure when backup files using HDFS filesy…
b15af6d 
…stem interface (backport #53679) (#54448)

Signed-off-by: srlch <[email protected]>
maggie-zhu pushed a commit to maggie-zhu/starrocks that referenced this pull request Jan 6, 2025
@srlch
[BugFix] Fix retry upload failure when backup files using HDFS filesy…
ed28276 
…stem interface (StarRocks#53679)

Signed-off-by: srlch <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trueeyu trueeyu trueeyu approved these changes

@luohaha luohaha luohaha approved these changes

@kevincai kevincai kevincai approved these changes

Assignees

@srlch srlch

Labels
3.2-merged 3.3-merged 3.4-merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Backup bug: Cannot truncate a file by hdfs writer
4 participants
@srlch @kevincai @luohaha @trueeyu