[BugFix] Set has delete for tables replicated by the starrocks data migration tool #54081

xiangguangyxg · 2024-12-19T03:36:25Z

Why I'm doing:

The has delete flag is not set in tables replicated by the starrocks data migration tool, may cause be crash when query.

What I'm doing:

Set has delete for tables replicated by the starrocks data migration tool.

Fixes #issue

What type of PR is this:

Does this PR entail a change in behavior?

Yes, this PR will result in a change in behavior.
No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

Interface/UI changes: syntax, type conversion, expression evaluation, display information
Parameter changes: default values, similar parameters but with different default values
Policy changes: use new policy to replace old one, functionality automatically enabled
Feature removed
Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

I have added test cases for my bug fix or my new feature
This pr needs user documentation (for new or modified features or behaviors)
- I have added documentation for my new feature or new function
This is a backport pr

Bugfix cherry-pick branch check:

fe/fe-core/src/main/java/com/starrocks/replication/ReplicationJob.java

fe/fe-core/src/main/java/com/starrocks/persist/OperationType.java

…igration tool Signed-off-by: xiangguangyxg <[email protected]>

sonarqubecloud · 2024-12-19T11:27:01Z

Quality Gate passed

Issues
6 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

github-actions · 2024-12-19T13:41:05Z

[Java-Extensions Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

github-actions · 2024-12-19T13:41:40Z

[FE Incremental Coverage Report]

❌ fail : 8 / 26 (30.77%)

file detail

	path	covered_line	new_line	coverage	not_covered_line_detail
🔵	com/starrocks/persist/EditLog.java	0	2	00.00%	[1544, 1545]
🔵	com/starrocks/replication/ReplicationJob.java	7	22	31.82%	[635, 636, 639, 640, 669, 670, 676, 677, 679, 680, 683, 686, 689, 690, 691]
🔵	com/starrocks/server/LocalMetastore.java	1	2	50.00%	[4144]

github-actions · 2024-12-19T13:42:17Z

[BE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

github-actions · 2024-12-20T02:09:15Z

@Mergifyio backport branch-3.4

github-actions · 2024-12-20T02:09:16Z

@Mergifyio backport branch-3.3

github-actions · 2024-12-20T02:09:18Z

@Mergifyio backport branch-3.2

mergify · 2024-12-20T02:09:19Z

backport branch-3.4

✅ Backports have been created

#54136 [BugFix] Set has delete for tables replicated by the starrocks data migration tool (backport #54081) has been created for branch branch-3.4

github-actions · 2024-12-20T02:09:19Z

@Mergifyio backport branch-3.1

mergify · 2024-12-20T02:09:24Z

backport branch-3.3

✅ Backports have been created

#54137 [BugFix] Set has delete for tables replicated by the starrocks data migration tool (backport #54081) has been created for branch branch-3.3 but encountered conflicts

mergify · 2024-12-20T02:09:25Z

backport branch-3.2

✅ Backports have been created

#54138 [BugFix] Set has delete for tables replicated by the starrocks data migration tool (backport #54081) has been created for branch branch-3.2 but encountered conflicts

mergify · 2024-12-20T02:09:27Z

backport branch-3.1

✅ Backports have been created

#54139 [BugFix] Set has delete for tables replicated by the starrocks data migration tool (backport #54081) has been created for branch branch-3.1 but encountered conflicts

…igration tool (#54081) Signed-off-by: xiangguangyxg <[email protected]> (cherry picked from commit d89bd1b)

…igration tool (#54081) Signed-off-by: xiangguangyxg <[email protected]> (cherry picked from commit d89bd1b) # Conflicts: # fe/fe-core/src/main/java/com/starrocks/replication/ReplicationJob.java

…igration tool (#54081) Signed-off-by: xiangguangyxg <[email protected]> (cherry picked from commit d89bd1b) # Conflicts: # fe/fe-core/src/main/java/com/starrocks/persist/OperationType.java # fe/fe-core/src/main/java/com/starrocks/replication/ReplicationJob.java

…igration tool (backport #54081) (#54136) Co-authored-by: xiangguangyxg <[email protected]>

…igration tool (backport #54081) (#54137) Signed-off-by: xiangguangyxg <[email protected]> Co-authored-by: xiangguangyxg <[email protected]>

…igration tool (backport #54081) (#54138) Signed-off-by: xiangguangyxg <[email protected]> Co-authored-by: xiangguangyxg <[email protected]>

…igration tool (backport #54081) (#54139) Signed-off-by: xiangguangyxg <[email protected]> Co-authored-by: xiangguangyxg <[email protected]>

xiangguangyxg requested a review from a team as a code owner December 19, 2024 03:36

wanpengfei-git added the META-REVIEW label Dec 19, 2024

wanpengfei-git requested a review from a team December 19, 2024 03:36

github-actions bot added 3.4 3.3 3.2 3.1 labels Dec 19, 2024

mergify bot assigned xiangguangyxg Dec 19, 2024

starrocks-cr bot reviewed Dec 19, 2024

View reviewed changes

fe/fe-core/src/main/java/com/starrocks/replication/ReplicationJob.java Show resolved Hide resolved

gengjun-git reviewed Dec 19, 2024

View reviewed changes

fe/fe-core/src/main/java/com/starrocks/persist/OperationType.java Outdated Show resolved Hide resolved

[BugFix] Set has delete for tables replicated by the starrocks data m…

3795792

…igration tool Signed-off-by: xiangguangyxg <[email protected]>

xiangguangyxg force-pushed the fix_has_delete branch from 5d80211 to 3795792 Compare December 19, 2024 11:20

gengjun-git approved these changes Dec 19, 2024

View reviewed changes

wyb approved these changes Dec 19, 2024

View reviewed changes

wyb enabled auto-merge (squash) December 19, 2024 11:56

andyziye disabled auto-merge December 20, 2024 02:08

andyziye merged commit d89bd1b into StarRocks:main Dec 20, 2024
53 of 54 checks passed

github-actions bot removed 3.4 3.3 labels Dec 20, 2024

github-actions bot removed the 3.2 label Dec 20, 2024

github-actions bot removed the 3.1 label Dec 20, 2024

mergify bot pushed a commit that referenced this pull request Dec 20, 2024

[BugFix] Set has delete for tables replicated by the starrocks data m…

f5af854

…igration tool (#54081) Signed-off-by: xiangguangyxg <[email protected]> (cherry picked from commit d89bd1b)

This was referenced Dec 20, 2024

[BugFix] Set has delete for tables replicated by the starrocks data migration tool (backport #54081) #54136

Merged

[BugFix] Set has delete for tables replicated by the starrocks data migration tool (backport #54081) #54137

Merged

mergify bot mentioned this pull request Dec 20, 2024

[BugFix] Set has delete for tables replicated by the starrocks data migration tool (backport #54081) #54138

Merged

18 tasks

mergify bot mentioned this pull request Dec 20, 2024

[BugFix] Set has delete for tables replicated by the starrocks data migration tool (backport #54081) #54139

Merged

18 tasks

wanpengfei-git pushed a commit that referenced this pull request Dec 20, 2024

[BugFix] Set has delete for tables replicated by the starrocks data m…

dbd6169

…igration tool (backport #54081) (#54136) Co-authored-by: xiangguangyxg <[email protected]>

github-actions bot added the 3.4-merged label Dec 20, 2024

github-actions bot added the 3.3-merged label Dec 20, 2024

github-actions bot added 3.2-merged 3.1-merged labels Dec 20, 2024

xiangguangyxg deleted the fix_has_delete branch December 20, 2024 04:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[BugFix] Set has delete for tables replicated by the starrocks data migration tool #54081

[BugFix] Set has delete for tables replicated by the starrocks data migration tool #54081

xiangguangyxg commented Dec 19, 2024

sonarqubecloud bot commented Dec 19, 2024

github-actions bot commented Dec 19, 2024

github-actions bot commented Dec 19, 2024

github-actions bot commented Dec 19, 2024

github-actions bot commented Dec 20, 2024

github-actions bot commented Dec 20, 2024

github-actions bot commented Dec 20, 2024

mergify bot commented Dec 20, 2024 •

edited

Loading

github-actions bot commented Dec 20, 2024

mergify bot commented Dec 20, 2024 •

edited

Loading

mergify bot commented Dec 20, 2024 •

edited

Loading

mergify bot commented Dec 20, 2024 •

edited

Loading

[BugFix] Set has delete for tables replicated by the starrocks data migration tool #54081

[BugFix] Set has delete for tables replicated by the starrocks data migration tool #54081

Conversation

xiangguangyxg commented Dec 19, 2024

Why I'm doing:

What I'm doing:

What type of PR is this:

Checklist:

Bugfix cherry-pick branch check:

sonarqubecloud bot commented Dec 19, 2024

Quality Gate passed

github-actions bot commented Dec 19, 2024

[Java-Extensions Incremental Coverage Report]

github-actions bot commented Dec 19, 2024

[FE Incremental Coverage Report]

file detail

github-actions bot commented Dec 19, 2024

[BE Incremental Coverage Report]

github-actions bot commented Dec 20, 2024

github-actions bot commented Dec 20, 2024

github-actions bot commented Dec 20, 2024

mergify bot commented Dec 20, 2024 • edited Loading

✅ Backports have been created

github-actions bot commented Dec 20, 2024

mergify bot commented Dec 20, 2024 • edited Loading

✅ Backports have been created

mergify bot commented Dec 20, 2024 • edited Loading

✅ Backports have been created

mergify bot commented Dec 20, 2024 • edited Loading

✅ Backports have been created

mergify bot commented Dec 20, 2024 •

edited

Loading

mergify bot commented Dec 20, 2024 •

edited

Loading

mergify bot commented Dec 20, 2024 •

edited

Loading

mergify bot commented Dec 20, 2024 •

edited

Loading