fix(react-query): eslint-plugin-query now working with vanilla js #8322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TkDodo
reviewed
Nov 22, 2024
packages/eslint-plugin-query/src/utils/detect-react-query-imports.ts
Outdated
Show resolved
Hide resolved
|
View your CI Pipeline Execution ↗ for commit 36ea4f4.
☁️ Nx Cloud last updated this comment at |
TkDodo
approved these changes
Nov 22, 2024
|
there’s a lint error because typescript thinks the check is unnecessary: you must likely disable the linter for this line |
This should make it pass the eslint-plugin test
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8322 +/- ##
===========================================
+ Coverage 46.26% 88.22% +41.95%
===========================================
Files 199 15 -184
Lines 7532 501 -7031
Branches 1720 186 -1534
===========================================
- Hits 3485 442 -3043
+ Misses 3668 45 -3623
+ Partials 379 14 -365
|
|
Hey, just here to bring attention back to this PR I want to ask if there's any reason why it hasn't been merged yet? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix the issue with detecting imports in both TypeScript and JavaScript files, I modify the
ImportDeclarationhandler to handle cases whereimportKindmight be undefined.The key change is adding
node.importKind === undefinedto the condition. This ensures the import detection works for both TypeScript (whereimportKindis explicitly 'value') and JavaScript (whereimportKindis undefined).This modification should resolve the lint plugin's compatibility issue with vanilla JavaScript apps by allowing import detection regardless of the
importKindvalue.closes #8257