fix(vue-query): avoid use sync for watch that cause unnecessary requests
#8443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mini-ghost
changed the title
queryKey match the current value of ref used insidequeryKey match the current value of ref used inside
|
View your CI Pipeline Execution ↗ for commit 0ec37c7.
☁️ Nx Cloud last updated this comment at |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8443 +/- ##
===========================================
+ Coverage 46.26% 71.01% +24.74%
===========================================
Files 199 19 -180
Lines 7532 483 -7049
Branches 1720 136 -1584
===========================================
- Hits 3485 343 -3142
+ Misses 3668 110 -3558
+ Partials 379 30 -349
|
Mini-ghost
changed the title
queryKey match the current value of ref used insidesync for watch that cause unnecessary requests
|
It seems this change might have broken I'll look into it further, but for now I've noticed that when a query is marked as stale and used in |
|
Never mind, the issue was on my side. Here's a "reproduction" that can be used later to ensure everything keeps working. 👍🏻 https://codesandbox.io/p/sandbox/issue-tanstack-query-queries-y6rlg6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked issue
enabled#5996Description
In PR #7942, attempting to change
watch's{ flush: 'sync' }to{ flush: 'post' }or removing it might lead to the same issues as #5910 and #5996.This PR removes
{ flush: 'sync' }and ensures proper handling ofrefreshto prevent the issue in #5910 wherequeryKeyretrieves stale data.If there are any considerations I may have missed, please kindly let me know. Thank you!