Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to @erquhart/[email protected] #327

Merged
merged 3 commits into from
Dec 29, 2024

Conversation

erquhart
Copy link
Contributor

@erquhart erquhart commented Dec 29, 2024

This PR adds netlify.toml with a custom production build command for Convex.

If you don't want this approach, I can drop it and a team member with access can update the value directly in the Netlify dashboard. The config is only currently set to override the build command for production and nothing else, but can be extended as you see fit.

In either case, the CONVEX_DEPLOY_KEY env var will need to be set in the Netlify dashboard: https://docs.convex.dev/production/hosting/netlify#deploying-to-netlify

Also fixes the dev command so both vinxi and convex can exit properly on ctrl +c.

Copy link

netlify bot commented Dec 29, 2024

Deploy Preview for tanstack ready!

Name Link
🔨 Latest commit c3ca05e
🔍 Latest deploy log https://app.netlify.com/sites/tanstack/deploys/677193734770bb0008f342d5
😎 Deploy Preview https://deploy-preview-327--tanstack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 56 (🔴 down 29 from production)
Accessibility: 95 (no change from production)
Best Practices: 83 (🔴 down 9 from production)
SEO: 84 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@tannerlinsley tannerlinsley merged commit f8e566d into TanStack:main Dec 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants