-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Special syntax to disable tag name checking #110
Conversation
- also added a base support of prefixed tags - also fixed a dashed tags support
Is it possible to override |
case PrefixedName(prefix, localPart) => | ||
localPart.split(':').foldLeft(q"$objectAccess.${TermName(NameTransformer.encode(prefix))}") { | ||
(prefixExpr, segmentName) => | ||
q"$prefixExpr.${TermName(NameTransformer.encode(segmentName))}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change enables svg
tags in the future by simply adding an additional val svg: scalatags.jsdom.SvgTags
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh! Very good! I am glad to hear it.
But when I was writing this, I was thinking about different thing (I am planning to propose a discussion about this in near future 😉). In any case, I suppose that support of an element namespace is a useful feature for Binding.scala
I merged this PR with a little change (using @glmars Thank you! You introduced so many wonderful features in Binding.scala. |
} | ||
|
||
override lazy val data = new DynamicDataTag() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A good hack 👍
If you like it, I like too 😄
Thank you for the excellent library! |
Introducing a special syntax to disable tag name checking (#43 (comment)):
Unfortunately, it is not possible to use the same syntax as for attributes, because
data
name is already busy (there isdata
html tag).I have selected a
raw:
prefix (similar toraw""" """
string interpolator :) )