CHANGELOG.md

Changelog

• This file will be updated whenever a new release is put into production.
• Any problems should be reported via the "report an issue" link in the footer of the application.

v5.5.6 - 2016-03-07

Fixed

• CSV Import can handle CR line endings (#1438).
• Reservations now correctly identifies blackout conflicts (#1489).
• Various UI bugs fixed: equipment model show table and checkout restrictions (#1492).
• Terms of Service checkbox correctly determines if editable (#1497).
• Fixed some strange behavior with the availability calendar (#1498).
• Directly accessing /reservations/new now redirects to root_path (#1502).
• The contact form now correctly falls back to the admin e-mail if no separate e-mail is set (#1524).

Changed

• Reservations now defaults to deleting missed reservations after one week (#1491).
• The availability calendar now uses FullCalendar (#1498).

v5.5.5 - 2016-02-05

Fixed

• Updated Rails Admin to allow editing of reservations (#1449).
• The start and end dates of reports can now actually be changed (#1476).
• The reservation overdue parameter correctly updates when editing the due date of checked out reservations (#1479).

v5.5.4 - 2016-02-02

Fixed

• The quick new user modal form works again (#1421, #1469, #1471).
• All URL helpers now use the correct relative root with subdirectory deployment (#1424, #1465).
• Fixed the links to Paperclip uploads (#1425).
• Uploaded CSVs support extra columns (#1439).
• Daily rake tasks run sequentially; check-in emails now only send for checked-out reservations (#1446).

Changed

• Changed receipts page to include user search (#1420).

v5.5.3 - 2016-01-24

Fixed

• Resolved an issue where checked-out reservations were not being taken into account when validating availability (#1449).

v5.5.2 - 2016-01-18

Fixed

• Resolved an issue where all AdminMailer e-mails were not being delivered (#1426).
• Resolved an issue where late fees in e-mails were cumulative, not daily (#1433).

v5.5.1 - 2016-01-12

Fixed

• Fixed issue where most users couldn't hide announcements (#1339).
• The equipment model availability numbers no longer overflow when they are two digits long (#1363).
• Admins can again manually create new users when CAS authentication is enabled (#1370).
• Fixed integration of Capistrano with the whenever cron scheduler (#1373).
• Fixed missing affiliation LDAP lookup (#1375).
• Fixed broken cancel button on the quick new user model (#1376).
• Fixed issue with missing datepicker assets (#1377).
• The reservation history tables on user profiles are again sortable (#1378).
• Fixed broken link to pending reservations on equipment model page (#1379).
• Fixed broken "Total Stock" count on the equipment model table (#1380).
• Fixed migration that was leading to reservations being incorrectly marked as overdue (#1381).
• Removed extra padding from navbar due to #1377 (#1403).

Changed

• Updated jQuery UI and its associated Bootstrap theme (#1377).
• Updated the default sort order for the reservation history tables on user profiles (#1378).
• Updated jQuery Datatables (#1378).
• Reordered sections on the current reservations page (#1414).

Added

• Made archived reservations accessible through the reservations index page (#1383).

v5.5.0 - 2015-11-23

Fixed

• The dropdown menu that appears when clicking on the reserver in a list of reservations is no longer blocked in a short table (#724).
• Importing users when using CAS now correctly sets their cas_login (#1272).
• Resolved issues with an earlier migration that would fail when trying to update an old database (#1330).
• Fixed issue with FontAwesome asset files in production (#1342).
• Fixed broken search results partial (#1344).
• Resolved issue with missing logs in non-Heroku deployments (#1345).
• Fixed an issue where requirements could not be applied to users (#1354).
• The secret token is now appropriately set by the relevant environment variable (#1356).

Changed

• Multiple equipment items of a given equipment model can no longer have the same non-blank serial number (#296).
• Made equipment model table more informative for patrons (#1199).
• The reservation note for creation now includes the name of the reserver (#1250).

v5.4.0 - 2015-10-26

Fixed

• Setup script for initial user now doesn't echo the typed password (#1304).
• Addressed a versioning issue with Capistrano (#1306).
• The seed-script-created superuser can now login in CAS mode (#1320).
• Actually fixed the user authentication initializer allowing both CAS and password authentication to be used (#1324).

Added

• ENV variable 'LOG_EMAILS' to log more detailed information upon sending any email (#1127).
• Email notifcations for requests that expire (#1203).

v5.3.0 - 2015-09-21

Fixed

• Fixed issues with reservation renewals and added tests (#416, #1218).
• Reservation scopes refactored (#462).
• Equipment Items and other deactivate-able resources can now be destroyed using Rails Admin (#1062).
• Fixed broken calendar logic (#1218).
• Forgetting to check off the ToS checkbox during checkout no longer causes checkout to fail silently (#1227).
• ToS acceptance is no longer saved if checkout doesn't succeed (#1227).
• Trying to make a reservation with an empty cart now redirects properly to the last page you were on (#1235).
• Autocomplete now works on Heroku / when using a PostgreSQL database (#1237).
• Several issues with e-mails were addressed (#1240).
• Admin users and superusers can no longer ban themselves (#1241).
• Attempting to check out equipment without checking off the ToS checkbox no longer updated the equipment item notes (#1243).
• Fixed visibility issue with autocomplete selection (#1251).
• Archiving a reservation with a missing reserver no longer fails (#1253).
• The Reservation#approved? method now correctly returns false for open requests (#1267).
• CSV upload now sanitizes for invalid UTF-8 characters (#1271, #1299).
• All Rake tasks were refactored to avoid the LocalJumpError when calling the bulk tasks defined for Heroku (#1276).
• The authorization initializer is now skipped if running commands with a pre-v4.1.0 database (#1282).

Added

• Added integration tests for basic reservation actions and Rails Admin routes (#416).
• Added Reservation flags for various attributes (see wiki, #462).
• Set up Capistrano deployment script (#1074).
• Added quantity fields to cart items (#1114).
• Added the ability to view returned overdue reservations from the reservations index page along with their late fees (#1121).
• Checkout receipts are now sent automatically on checkout (#1215).
• Added an optional admin notification upon Reservation creation (#1284).
• Added an optional cap for equipment item late fees (#1285).
• Added kill switch for user e-mails (#1286).

Changed

• Reservation approval status and status method are now consolidated into a status enum (#462).
• Equipment item notes can now only be viewed by admin roles and higher (#1245).
• Equipment can now be checked-in for banned users (#1246).
• TOS checkbox on checkout/checkin page moved to the left of the notice text for increased salience and UX consistency (#1259).
• The Reservation status / flagging tasks have been removed from the flag_reservations namespace and put in separate files (#1273).
• The cron task that flags overdue reservations has been updated to check all past reservations (#1274).

v5.2.2 - 2015-04-20

Fixed

• Forgetting to check off the ToS checkbox during checkout no longer causes checkout to fail silently (#1227).

v5.2.1 - 2015-04-14

Fixed

• Skipped authentication initializer when users table does not yet exist; resolves issue where new Heroku installation failed due to asset precompilation running before database migrations.
• Added seed script gems to heroku group in the Gemfile; resolves regression due to #1165 (#1226).

v5.2.0 - 2015-04-13

Fixed

• Refactored qualifications logic from catalog views (#980).
• Fixed broken pdf uploads on Firefox (#1016).
• Fixed user import for CAS and LDAP users (#1094).
• Rails Admin can now manipulate all important models in the database (#1122).
• Re-added links to flash messages (#1124).
• Fixed broken checkout / checkin procedures (#1139).
• 3rd party assets were moved to a separate directory (#1142).
• Application config settings now pre-check for existing configuration to prevent crashes when the configuration isn't initialized (#1144).
• EquipmentModels with uploaded documentation no longer crash (#1181).
• Banned users can no longer have reservations created for them or equipment checked out to them (#1185).
• Fixed broken view on equipment model import (#1192).

Added

• Added flash error when trying to access non-existent records (#927).
• Added pending reservations table to equipment model view (#987).
• Added table of equipment models to the category show view and improved the equipment model index table for admins (#1009).
• Added a guide for contributing to Reservations (#1056).
• Added more information to the EquipmentModel index page for checkout persons (#1082).
• Allowed switching between password and CAS authentication (#1106).
• Allowed users to be "remembered" when using password authentication (#1109).

Changed

• Added new logo and default favicon (#194).
• Completely overhauled user emails (#665, #938).
• Renamed EquipmentObjects to EquipmentItems (#1081).
• Removed links to EquipmentItems index page because of performance issues (#1082).
• Removed seed script gems from default group in Gemfile (#1165).

v5.1.0 - 2015-02-23

Fixed

• Calendar views no longer overflow on some browsers (#846).
• Date and time zone handling is now standardized; additionally, reservation start and due dates are now stored as Dates rather than as DateTimes (#939).
• The handling of missed reservations was improved, and e-mails of missed open requests are no longer sent (#1031).
• The late checkin e-mail is no longer sent if the late fee due is zero (#1064).
• The extra 1px at the bottom of the navbar has been removed (#1111).
• Minor bugs with equipment import were fixed (#1140).
• Calendar cells can no longer be clicked on, preventing apparently incorrect cart updates (#1152).

Added

• Reservations is now set up for Heroku deployment (please see the Deployment Guide for more information, #275).
• There is now a badge on user profile pages indicating that they have open requests (#1028).

Changed

• Bootstrap was updated to v3.3 and the entire UI of the app was overhauled (#245).
• The cart validations code was substantially refactored (#1097).
• The equipment item link on the reservation page now goes to the equipment item page instead of the equipment model page (#1159).
• The version of Rails was updated to 4.1.9 (#600).
• All of the dependencies were updated to the latest versions and the Gemfile was cleaned up (#245, #600).
• Added a link to the reservation in emails (#1102).

Removed

• The .env file was removed from the repository; the .env.example file may be copied for local use (#1104).
• The dynamic_form gem was removed (#1110).
• The yajl-ruby gem was removed (#600).

v5.0.0 - 2015-01-12

Important

This release fundamentally changes how Reservations is configured (see the (wiki) for more details). You will likely have to rework how Reservations is deployed and hosted for it to work properly when updating to this version.

Fixed

• Two intermittently failing tests have been commented out and a third has been fixed (#1059).
• Changing the cart dates now updates the catalog availability descriptions (#1060).

Added

• Fleshed out and polished guest user functionality (#175).
• Adding or removing an item from the cart now updates the availability count in the catalog (#718).
• Carts are now limited to 100 items to avoid cookie overflow (#997).
• The equipment model page now renders the 'Add to Cart' button differently depending on model status (#1053).
• Reservation notes now indicate if failed validations were overriden during reservation creation (#1054).
• Code quality tools (currently rubocop with support for JS linters as well) have been added to the TravisCI build (#1075).
• The cart is now checked for equipment models that have been destroyed in between requests to avoid rendering issues (#1085).

Changed

• Environment variables are now used to configure Reservations. These can be spoofed using the dotenv-deployment gem if desired (#683).
• The reservations index view has been overhauled and now is date-restricted; this resolves the issue where loading the 'Returned' reservations table would hang the browser on instances with large numbers of reservations (#708).
• The reports code has been completely refactored and heavily improved (#994).
• The seed script has been completely refactored; it now includes several modes of operation and has been heavily optimized (#629, #1071).
• The authorization statements used to restrict equipment activation / deactivation have been rewritten for legibility (#1019).

Removed

• The Yale dependencies in the LDAP configuration have been removed to allow for the use of any LDAP server. (#653).
• An unnecessary before_filter has been removed from the ApplicationController (#1072).

v4.1.0 - 2014-12-01

Added

• Added an "archive" action for reservations to deal with unusual circumstances (#728).
• Added a persistent history for equipment objects / items (#273).
• Authentication is now handled by the Devise gem. Added email/password authentication (#2).
• Equipment switches are now noted in both relevant reservations (#1022).
• secrets.yml is now used for sensitive settings (#1018).
• There is now a link to Rails Admin in the navbar for superusers (#965).
• The dotenv gem is now used to spoof environment variables in development (#694).
• Equipment items are now returned before deactivation (#288).
• Admins can now disable user creation by patrons and checkout persons (#622).
• Reservation renewals are now logged in the reservation notes (#920).
• Admins are now warned if deactivating a category or equipment model with current or future reservations (within the next week) (#1040).
• Deactivating a category or an equipment model will now archive all checked-out reservations with associated equipment items (#1040).

Changed

• Deactivating an equipment item now archives relevant reservations if they're currently checked out (#288).
• Reservation notes have been improved and include links for easier history tracking (#999, #1021).
• Rails Admin now has proper authorization (#973).
• spin.js has been replaced with a Font Awesome icon for the cart spinner (#777).
• The number of days after which a missed reservation is deleted can now be defined by admins (#594).
• Blackout dates can no longer be created when the due dates of existing reservations would conflict with said blackout date (#562).

Removed

• Took out the logging functionality of paper_trail in lieu of recently added reservation and equipment history features (#1033).
• A number of broken links left over from earlier versions were removed (#957).
• The cart was removed from a number of views (#776).

v4.0.1 - 2014-11-03

Important

This release has not been tested under production conditions. We recommend waiting for a release that has undergone more testing.

Fixed

• Fixed an issue where links in the request e-mail were broken (#1017).
• Moved the email link hostname back to the environment files (#1017).
• Fixed an issue where requiring phone numbers with existing users in the database would cause problems (#675, #1008).
• Fixed an issue where some application options defaulted to nil instead of '' and associated problems (#947).
• Updated link_to confirmation syntax for Rails 4 (#990).

Added

• Added a confirmation dialog when deactivating an item would cause that model to be overbooked within the coming week (#983).

Changed

• Announcements are now rendered in Markdown so they can include links and formatting (#1027).
• Majorly refactored the Reservations controller (#836, #882).
• Moved the session from the database to a cookie to improve performance (#880).
• Added fallback version number derived from CHANGELOG (#968).
• Added a "Delete" button to the Requirements "show" page (#803).

v4.0.0 - 2014-10-05

Important

This release includes an upgrade to Rails 4 and a large number of other changes; it has not been tested under production conditions. We recommend waiting for a release that has undergone more testing.

Fixed

• Fixed CodeClimate testing coverage (#682).
• Fixed unescaped HTML on some views (#781, #860).
• Fixed broken migration due to switch to Rails Admin (#853, see below).
• The 'superuser' option now appears in the View Mode menu from any view mode when logged in as a superuser (#976).

Added

• The maximum reservation length is now shown on the equipment model page (#303).
• Users are now notified via e-mail when requests have been processed (#726).
• Reservation notes are now edited in append mode (#752).

Changed

• Updated to Rails 4.1.4 (#585).
• Switched to Rails Admin from Active Admin (#691).
• Added equipment model-specific validation parameters (#749).
• Reorganized all JavaScript files (#234).
• Added .ruby-version file (#697).
• Added testing coverage for the Reservations controller (#874).
• Added persistent flash for superusers in other view modes (#974).
• Replaced Airbrake with Party Foul (#501).
• The first user is now created as a superuser (#753).

v3.4.10 - 2015-04-20

Fixed

• Forgetting to check off the ToS checkbox during checkout no longer causes checkout to fail silently (#1227).

v3.4.9 - 2015-03-16

Fixed

• Banned users can no longer have reservations created for them or equipment checked out to them (#1185).

v3.4.8 - 2014-10-26

Fixed

• Fixed an issue where links in the request e-mail were broken (#1017).
• Moved the email link hostname back to the environment files (#1017).

Changed

• Announcements are now rendered in Markdown so they can include links and formatting (#1027).

v3.4.7 - 2014-10-12

Changed

• Modified schedule.rb so that the cron jobs of multiple Reservations instances on the same server don't overload the server.

v3.4.6 - 2014-10-06

Fixed

• Improved performance of sending reservations notes emails
• Actually finally resolved the issue where links in e-mails were broken (#868).

v3.4.5 - 2014-09-22

Fixed

• Ensured that only reservations with notes or missed procedures were being sent in the notes e-mail (#948).
• Finally resolved the issue where the links in e-mails were broken (#868).
• Fixed an issue where the catalog was showing negative equipment availability (#982).
• Fixed some holes in our admin and default new user permissions (#966).

v3.4.4 - 2014-09-02

Added

• An email will now be sent to the administrators when a new request is created (#943).

Changed

• Made sure that there were no redundant prompts when a custom request prompt was defined (#940).

v3.4.3 - 2014-08-31

Fixed

• Fixed typo on the application settings form (#850).
• Fixed an issue where checkout persons could not use autocomplete (#857).
• Fixed an issue where items with unrestricted checkout lengths could not be added to the cart (#848).
• Fixed an issue where the overdue fines sent via e-mail were incorrect (#876).
• Fixed an issue where the calendar availability was incorrect (#883).
• Ensured that the empty cart button completely resets the cart (#845).
• Fixed an issue where all links in e-mails were broken (#868).
• Fixed an issue where the overdue scope was including missed reservations (#893).
• Fixed an issue where the reservation notes e-mails were not being sent (#906).
• Fixed the equipment model change popup to only show when relevant (#890).
• Fixed an issue where the notes field in the check-out form was being populated with prior notes (#915).
• Fixed an issue where the renewal button would be active even when the max renewal length was zero (#916).
• Fixed an issue where the app wasn't properly counting reservations that started on the same day as the cart start date for availability (#932).
• Fixed an issue where renewals were including the start date of any upcoming reservations that required the item (#932).

Added

• Added equipment import functionality (#494).
• Added an option to disable renewals (#916).
• Added a customizable prompt to the reservation request page (#746).

Changed

• Made version number visible to all users (#856).
• The request notes are now shown on the request review page (#901).
• Made the search box more noticable (#293).

v3.4.2 - 2014-07-28

Fixed

• Added requirements to cart validations to prevent unqualified users from being granted reservations inappropriately (#763)
• Tweaked the check-in UI to fix an issue where clicking in the notes field would toggle item selection (#840)
• Updated scopes to ensure that reservations could be checked out any time before due date (#844)

v3.4.1 - 2014-07-27

Changed

• Updated Ruby version to 2.1.2

v3.4.0 - 2014-07-27

Fixed

• Fixed failing tests in user_mailer_spec (#643)
• Ensured that overdue equipment items could not be checked out (#625)
• Fixed typo in ability.rb (#649)
• Ensured that the new cart would not break the app for existing users (#676)
• Fix edge case new user creation when :possible_netid is not set (#732)
• Prevented infinite redirect loop in edge case when a user tries to log on to the system before the admin has set up the application (#684)
• Updating the cart no longer breaks the catalog pagination links (#531)
• Deleting Blackout Dates now works in all cases (#808)
• Checkout persons can no longer see the Import Users button (#810)
• Reservations checked in on their due-date are no-longer counted as overdue (#785)
• Block patrons from URL-hacking and creating new users (#823)
• Fixed a bug wherewith patrons were unable to edit their own profiles (#830)
• Fixed broken user form (#787)

Added

• Added benchmarking for speed-testing (#574)
• Added version number to footer and app settings page (#560)
• Added continuous integration testing w/ TravisCI (#641)
• Added testing coverage w/ CodeClimate (#634)
• Added reservation notes entry for validation-failing requests (#502)
• Blackouts automatically are removed after an admin-configurable period (#654, #242)
• User deactivation/reactivation has been changed to user ban/unban (#529)

Changed

• Completely overhauled cart (#587)
• Completely overhauled cart and reservation validations (#644, #343)
• Refactored the Reservation model (#614)
• Greatly improved catalog render times (#628)
• Updated kaminari gem (#657)
• Refactored UsersController#new (#660)
• Further speed enhancements for the catalog and checkout (#734)
• Removed deletion of reservations when deactivating equipment (#706)
• Further speed enhancements for the reservation lists page (#655)
• Refactor blackout system (#654)
• Add full coverage for reservation checkin and checkout (#679)
• Autocomplete improvements (#620)
  • Clicking a user name in find user suggestions directs automatically to the manage reservation page
  • Clearing a reserver name in the cart resets the cart to the current user
  • Typing a full name with space doesn't delete the query
• Make everything a lot faster by not counting all users on every request (#759)
• Refactor checkin and checkout (#666)
• Index users table for speed optimization (#755)
• Clarified and refactored reservation renewal code (#674)
• Restore Checkin box location from the v3.1-era (#819)

Removed

• It's no-longer possible to delete categories, equipment models, or equipment items. Deactivation is now the only method (#802)

v3.3.0 - 2014-07-22

Important

Please don't use this version. Use 3.4.x instead: it has undergone more bugtesting.

Fixed

• Fixed catalog pagination not working correctly (#533)
• Fix bug preventing recurring blackouts not being able to be created if they are the first blackout of the application (#589)
• Fix bug causing reservation validations to check all reservations ever made by the user (#570)
• Banned users are now actually banned (#564)
• Can now edit and update equipment models that have no checkin/checkout procedures (was crashing application earlier) (#558)
• Fixed off-by-one-day error with the blackout dates (#525)
• Pointed reservation edit cancel to correct view (#316)

Added

• Added ability to swap equipment objects for checked out reservations (#536)
• Added the ability to add a deactivation reason to equipment objects (#332)
• Added a comprehensive auditing/logging feature (#319)
• Enabled editing of email field in quick create user modal (#567)
• Set up ActiveAdmin and added superuser role for easy backup administration capabilities (#546)
• Added overdue-checkin emails to both patron and admin, noting total fees (#317)
• Reservation Requests, for patrons who would like to request extended reservations (or other reservations that otherwise would not be valid) (#206)
• Calendar view of available equipment items (#12)

Changed

• Added flash to notify admins when viewing Reservations as a different user (#542)
• Revamped authentication system with CanCan gem (#419)
• Revamped the check-in UX (#172, #568)
  • Added ability to click div to select the checkbox
  • Added color cues to indicate selection and overdue status
  • Added overdue glyph
• Upgraded to Ruby v2.1.1 and Rails v3.2.14 (#535)
• Added hidden field to datepickers for blackouts and announcements to remove unnecessary date parsing (#580)
• Improved seed script, adding minimal mode and reducing inconvenience (#578)
• Updated developer wiki and launched companion documentation site (#532)
• Made all emails much more informative and included links to relevant pages on Reservations app. (#519)
• Refactored update method in ReservationsController (#354)
• Upgraded to Font-Awesome v4.1.0. (#616)
• Vastly-improved rspec testing coverage.

Removed

• Removed test/unit (#612) in favor of markèd improvement of rspec coverage (#403, #404)

v3.2.0 - 2014-06-10

Fixed

• Disabled cart during update and added JS spinner/success flash message to prevent cart changes from not being saved (#528)
• Fixed duplicate flash message for blackout dates (#420, #445)
• Fixed issue where the Users page would display a link when the nickname was set to nil (#466)
• Fixed issue where checkin / checkout steps could not be deleted (#470)
• Fixed database.yml example for Ubuntu where all databases had the same name (#472)
• Fixed test for the cart date where DateTime.tomorrow was used instead of DateTime.now.tomorrow (#491)

Added

• Added flash for checkout persons when making a reservation for the current day (#321)
• Added admin interface for setting up site-wide announcements (421, 447)

Changed

• Added Guard and Spork for faster testing (#490)

v3.1.0.alpha10 - 2014-03-26

Fixed

• Fix an error that was causing some emails to not send

v3.1.0.alpha9 - 2014-03-26

Fixed

• Slow reservation notification emails to send hourly instead of every 5 minutes
• Fix Chrome bug where remove button did not render correctly in the cart

v3.1.0.alpha7 - 2014-02-28

Bug Fixes

• Changed autocomplete field in cart to display the reserving for user without it disappearing

Added

• Quick add user from cart by typing their netID and clicking the + button
• Reservation note emails are now categorized by checkin and checkout