Skip to content
This repository has been archived by the owner on Jul 24, 2020. It is now read-only.

Contact form broken when no contact e-mail specified [v5.5] #1524

Closed
orenyk opened this issue Mar 8, 2016 · 2 comments
Closed

Contact form broken when no contact e-mail specified [v5.5] #1524

orenyk opened this issue Mar 8, 2016 · 2 comments
Assignees
@orenyk
Labels
diff: 2 pri: 5 type: bug
Milestone
5.5.6

Comments

@orenyk
Copy link
Contributor

orenyk commented Mar 8, 2016

It's working in development because of letter_opener (which apparently doesn't care about having a to address). On Heroku this broke:

2016-03-08T21:39:09.433916+00:00 app[web.1]: 
2016-03-08T21:39:09.433934+00:00 app[web.1]: Sent mail to  (9.1ms)
2016-03-08T21:39:09.433939+00:00 app[web.1]: Date: Tue, 08 Mar 2016 21:39:09 +0000
2016-03-08T21:39:09.433940+00:00 app[web.1]: From: [email protected]
2016-03-08T21:39:09.433942+00:00 app[web.1]: Subject: [Reservations Demo] my subject
2016-03-08T21:39:09.433941+00:00 app[web.1]: Message-ID: <56df467d69253_a3fef82c2199051261@8328af69-6f3a-457e-a2b7-9441f67b2c65.mail>
2016-03-08T21:39:09.433942+00:00 app[web.1]: Mime-Version: 1.0
2016-03-08T21:39:09.433943+00:00 app[web.1]: Content-Type: text/plain;
2016-03-08T21:39:09.433943+00:00 app[web.1]:  charset=UTF-8
2016-03-08T21:39:09.433944+00:00 app[web.1]: 
2016-03-08T21:39:09.433944+00:00 app[web.1]: Content-Transfer-Encoding: 7bit
2016-03-08T21:39:09.433946+00:00 app[web.1]: ---------------------
2016-03-08T21:39:09.433945+00:00 app[web.1]: this is a test e-mail
2016-03-08T21:39:09.437130+00:00 app[web.1]: ArgumentError (An SMTP To address is required to send a message. Set the message smtp_envelope_to, to, cc, or bcc address.):
2016-03-08T21:39:09.433946+00:00 app[web.1]: 
2016-03-08T21:39:09.437132+00:00 app[web.1]:   app/controllers/contact_controller.rb:11:in `create'
2016-03-08T21:39:09.433947+00:00 app[web.1]: 
2016-03-08T21:39:09.437133+00:00 app[web.1]: 
2016-03-08T21:39:09.437133+00:00 app[web.1]: 
2016-03-08T21:39:09.437117+00:00 app[web.1]: 
2016-03-08T21:39:09.437403+00:00 app[web.1]: source=rack-timeout id=0fa9422d-1e00-4c63-978c-27921a421a20 wait=6ms timeout=10000ms service=356ms state=completed
2016-03-08T21:39:09.433948+00:00 app[web.1]: Sent by my name from [email protected]
2016-03-08T21:39:09.435750+00:00 app[web.1]: Completed 500 Internal Server Error in 336ms (ActiveRecord: 6.3ms)

It should fall back to the admin e-mail. We might also want to back-port it to v5.5...
@orenyk orenyk added this to the 6.0.0 milestone Mar 8, 2016
@orenyk orenyk changed the title Contact form broken when no contact e-mail specified Contact form broken when no contact e-mail specified [v5.5?] Mar 8, 2016
@orenyk orenyk self-assigned this Mar 22, 2016
@orenyk
Copy link
Contributor Author

orenyk commented Mar 22, 2016

Ok, turns out a few things are going on. First, our code never actually defaulted the contact e-mail to the admin e-mail, it was just that our setup script would copy over the admin e-mail if a separate contact e-mail wasn't entered. Secondly, we're not actually validating that a contact e-mail is present (or even a valid e-mail address), so we should probably do that. I'm messing around and will write up solutions for both v5.5 (to be snuck into v5.5.6) and v6.0.

orenyk added a commit that referenced this issue Mar 22, 2016
@orenyk
Resolve issues with contact form
25b7573 
Resolves #1524
- add AppConfig.contact_email to correctly default to admin e-mail when
  no contact e-mail is set
- add validations for AppConfig.contact_link_location to ensure it is a
  valid e-mail if it's not blank
- update the letter_opener gem to correctly raise an error if an e-mail
  doesn't have a to address set
- update seed and application setup script to assign valid e-mails to
  contact_link_location by default, as well as update factories
- add specs
orenyk added a commit that referenced this issue Mar 22, 2016
@orenyk
Resolve issues with contact form
d820bd6 
Resolves #1524
- add AppConfig.contact_email to correctly default to admin e-mail when
  no contact e-mail is set
- add validations for AppConfig.contact_link_location to ensure it is a
  valid e-mail if it's not blank
- update seed and application setup script to assign valid e-mails to
  contact_link_location by default, as well as update factories
- add specs

Conflicts:
	Gemfile.lock
@orenyk
Copy link
Contributor Author

orenyk commented Mar 22, 2016

Ok all done, issuing PR's now.

@orenyk orenyk modified the milestones: 5.5.6, 6.0.0 Mar 22, 2016
@orenyk orenyk changed the title Contact form broken when no contact e-mail specified [v5.5?] Contact form broken when no contact e-mail specified [v5.5] Mar 22, 2016
This was referenced Mar 22, 2016
Merged
Merged
orenyk added a commit that referenced this issue Mar 22, 2016
@orenyk
Resolve issues with contact form
d139897 
Resolves #1524
- add AppConfig.contact_email to correctly default to admin e-mail when
  no contact e-mail is set
- add validations for AppConfig.contact_link_location to ensure it is a
  valid e-mail if it's not blank
- update seed and application setup script to assign valid e-mails to
  contact_link_location by default, as well as update factories
- add specs
orenyk added a commit that referenced this issue Mar 29, 2016
@orenyk
Resolve issues with contact form
5866914 
Resolves #1524
- add AppConfig.contact_email to correctly default to admin e-mail when
  no contact e-mail is set
- add validations for AppConfig.contact_link_location to ensure it is a
  valid e-mail if it's not blank
- update the letter_opener gem to correctly raise an error if an e-mail
  doesn't have a to address set
- update seed and application setup script to assign valid e-mails to
  contact_link_location by default, as well as update factories
- add specs
orenyk added a commit that referenced this issue Mar 29, 2016
@orenyk
Resolve issues with contact form
f46ef5a 
Resolves #1524
- add AppConfig.contact_email to correctly default to admin e-mail when
  no contact e-mail is set
- add validations for AppConfig.contact_link_location to ensure it is a
  valid e-mail if it's not blank
- update seed and application setup script to assign valid e-mails to
  contact_link_location by default, as well as update factories
- add specs
orenyk added a commit that referenced this issue Mar 29, 2016
@orenyk
Resolve issues with contact form
b6ff50b 
Resolves #1524
- add AppConfig.contact_email to correctly default to admin e-mail when
  no contact e-mail is set
- add validations for AppConfig.contact_link_location to ensure it is a
  valid e-mail if it's not blank
- update the letter_opener gem to correctly raise an error if an e-mail
  doesn't have a to address set
- update seed and application setup script to assign valid e-mails to
  contact_link_location by default, as well as update factories
- add specs
zeffman pushed a commit that referenced this issue Sep 18, 2016
@orenyk @zeffman
Add modular reservations calendar
46b4d01 
Resolves #1360
- Add Calendarable controller concern to generate HTML, JSON, and
  iCalendar representations of all the reservations for a given
  resource
- Add calendarable routing concern and clean up config/routes.rb
- Add Reservation#end_date to find the last day for a reservation,
  status-dependent (with model specs)
- Add the associated controller specs as a shared example as well
  as feature specs for equipment models
- Add calendars for categories, equipment models, equipment items,
  and users
- Fix routing issue with jQuery-UI-Bootstrap assets

Add updated schema for Rails 4.2

Resolves #1517
- schema now has field limits, see issue for details

Clarify availability error messages

Closes #1242
   - change app/models/cart_validations.rb to tell
     maximum number of available items, pluralizing properly

Fix UI issues

Closes #1492
  - Change big-numbers mixin so font does not overflow table
  - Adjust equipment_model show table columns to align better
  - Add table_woo to CSS formatting to center rows vertically

Resolve issues with contact form

Resolves #1524
- add AppConfig.contact_email to correctly default to admin e-mail when
  no contact e-mail is set
- add validations for AppConfig.contact_link_location to ensure it is a
  valid e-mail if it's not blank
- update seed and application setup script to assign valid e-mails to
  contact_link_location by default, as well as update factories
- add specs

Add optional archival deactivation of equipment

Resolves #1384
- add autodeactivate_on_archive parameter to AppConfig
- move equipment item deactivation to a model method
- tweak ReservationsController#archive method to implement
  auto-deactivation
- add feature specs for reservation archiving
- add model specs for EquipmentItem#deactivate
- add controller specs for ReservationsController#archive with
  auto-deactivation
- FeatureHelpers#app_setup now deletes any pre-existing AppConfigs

Prevents duplicate items in search results

Resolves #933
- Flattens search results array before applying uniq
- Wrote test to check for duplicate results

Fix / replace availability calendar

Resolves #1498
- add FullCalendar-based availability calendar
- move availability calculations to private controller method
- add controller specs for availability
- remove legacy calendar code

Fix whenever / Capistrano integration

Resolves #1373
- use built-in whenever tasks

Fix view alignment of dates in reservation show

closes #1532
- minor edit in reservations show.html to remove wrapper around h4 headings
- p tag used to cause alignment problem

Remove Rails dependency from whenever.rb

Resolves #1542
- whoops

Fix rubocop error

Introduced in #1542, whoops again!

Request text is now shown after invalid cart edit

Resolves #1544
- moves request text assignment code to ReservationsHelper
- manually include ReservationsHelper in CatalogController

Update CHANGELOG for v6.0.0

Resolves #1362
- include changes in the v5.5.x releases

Update Travis status image in README

This was previously reflecting the status of the build from the most recently
pushed commit / PR, which is often red. To accurately reflect the health of the
project the status image will now only refer to builds from `master`.

Change default Heroku e-mail addon to Sendgrid

Resolves #1515
- update `devise_cas_authenticatable` to v1.7.1 to resolve logger issue

Clean up #1337
Resolves #1499
  - Include CsvExport in all relevant controllers
  - Add single category export

Overhaul availability

Resolves #1501
  - Availability methods all work as expected
  - Adds counter cache on equipment models for current overdue reservations
  - Reservation factory trait :past allows for creation of past
    reservations without skipping validations
  - New reservation model methods for counting reservations, attribute
    checking, and checking for overlapping

Seed script no longer generates reservations with impossible dates

Resolves #1229 and #1263
 - Seed script uses TimeHelpers to save reservations in the past,
   allowing validations to be run on them

Fix ElementNotFound feature test intermittent failure

Resolves #1514
  - Only create a second equipment model and item when necessary in
    feature specs
  - Replace nearly all AppConfig creations in tests with a mocked
    AppConfig
  - Get rid of most before(:all) callbacks
  - Minor refactor of a reservations controller spec

Update dependencies (May 2016)

Resolves #1553
- Highlights:
  - Update Ruby to 2.2.5
  - Update Devise to v4.1
  - Update Capybara to v2.7
- Email validators are now more permissive due to Devise update
- Capybara matchers no longer return hidden inputs by default
- Several new rubocop cops were implemented and dealt with

Update CHANGELOG for v6.1.0

Resolves #1548

Fix intermittent asset failure in specs

Resolves #1528
  - Mock relative root in application helper specs

Configure Hound CI

Resolves #1577

Add option for requests to block equipment availability

Resolves #1521

Refactor EquipmentModel Model spec

Resolves #1600

Add ESlint to Travis; only style check the diff

Resolves #1581
  - Adds 'rake check_style'
  - Fixes rubocop's TargetRubyVersion
  - Removes HoundCI config

Refactor EquipmentModels controller spec

Resolves #1587
 - Adds Mocker classes
 - Adds shared controller examples for successful and failed requests

Refactor periodic rake tasks to ActiveJobs

Resolves #1275
  - Add buttons to manually run periodic tasks
  - Moves all periodic tasks from rake to ActiveJob
  - Heavy refactoring of former rake tasks and their specs

Update ruby version in readme

Updated ruby version in readme (literally changed one character)

Refactor Reservation Model spec

Resolves #1554

Refactor EquipmentItems Controller spec

Resolves #1588

Refactor Reservations Controller Spec

Resolves #1586
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@orenyk orenyk

Labels
diff: 2 pri: 5 type: bug
Projects
None yet
Milestone
5.5.6
Development

No branches or pull requests
1 participant
@orenyk