Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for Laravel 11 #141

Merged
merged 4 commits into from
Mar 20, 2024
Merged

Add Support for Laravel 11 #141

merged 4 commits into from
Mar 20, 2024

Conversation

stefanzweifel
Copy link
Contributor

This PR updates the requirements in composer.json to support Laravel 11.

I ran the test suite on Github Actions in my fork. Results can be found here. (I temporarily added "minimum-stability": "dev" to run the tests)

The precedence_is_correct test is currently failing.

1) Hammerstone\Sidecar\Tests\Unit\EnvironmentTest::precedence_is_correct
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'app_env'
+'testing'

Maybe someone with more knowledge about the codebase or the new Laravel 11 changes knows what's going on here.

@stefanzweifel
Copy link
Contributor Author

@aarondfrancis Would be awesome if you could take a look at this PR and merge / tag a new version.
I think Laravel 11 is just around the corner. 👀

@thenabeel
Copy link

@aarondfrancis Since Laravel 11 is released, is there any possibility to get this PR merged?

@aarondfrancis aarondfrancis merged commit b9088e4 into aarondfrancis:main Mar 20, 2024
17 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants