feat: ability to run custom callback on timeout for Absinthe.Middleware.Async middleware #1184
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Async middleware sends an exit signal that kills the request and causes a 500 on timeout, as it uses
Task.await/2 under the hood. This PR adds the ability to pass
on_timeout/1
callback function tothe middleware and trigger it on timeout.
By default, it stops the current process with exit/1, as before.
The only potential issue may be that in case someone uses try/catch like this:
it won't work, as now it exits with
exit({:timeout, {Absinthe.Middleware.Async, :call, [task, timeout]}})
If we need to handle it, the only way that I see is to pattern match on options and call:
After I had already implemented the logic, I noticed that such a question had already been raised.