Add the specifiedBy type system directive #1193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maartenvanvliet
force-pushed
the
issues/918
branch
from
dcaeb29 to
c70f29f
Compare
kdawgwilk
approved these changes
Sep 13, 2022
See https://spec.graphql.org/October2021/#sec--specifiedBy for the specification Fixes absinthe-graphql#918
maartenvanvliet
force-pushed
the
issues/918
branch
from
bf75a01 to
9b0cb1c
Compare
benwilson512
approved these changes
May 13, 2023
| field :name, | ||
| type: non_null(:string), | ||
| resolve: fn _, %{adapter: adapter, source: source} -> | ||
| {:ok, adapter.to_external_name(source.name, :field)} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the specifiedBy type system directive to Absinthe. See the spec https://spec.graphql.org/October2021/#sec--specifiedBy for its definition.
Also encountered an issue with directive names not being transformed through the adapter in introspection.
Fixes #918