Add pipeline modifier option to Absinthe.run #1221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bernardd
force-pushed
the
run_pipeline_config
branch
from
3354a3f to
c1a8377
Compare
benwilson512
approved these changes
Feb 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the limitations of testing with
Absinthe.run/3is the inability to add custom pipeline phases. Doing so requires going through the full HTTP stack to test. That means that if there's a custom phase that is critical to your system's operation, it immediately rendersAbsinthe.run/3tests unusable.This change allows the specification of a pipeline modifier callback function which takes the default pipeline and options and returns the pipeline to be used in the tests.