CI housekeeping #1350
Open
CI housekeeping #1350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
List of changes: - Bump GitHub actions - Enable back OTP 25 / Elixir 1.17 in test matrix - Resolve dialyzer errors in Elixir 1.18 - Remove duplicate check on main branch upon a pull request - Support Elixir 1.18 to CI
kianmeng
commented
Jan 2, 2025
| @@ -48,7 +48,7 @@ defmodule Absinthe.Utils.Render do | |||
| end | |||
|
|
|||
| defp escape_string(<<char::utf8, rest::binary>>, acc) do | |||
| escape_string(rest, [acc | <<char::utf8>>]) | |||
| escape_string(rest, acc ++ [<<char::utf8>>]) | |||
| end | |||
There was a problem hiding this comment.
This resolves the following error with mix dialyzer on Elixir 1.18:
lib/absinthe/utils/render.ex:51:5:improper_list_constr
List construction (cons) will produce an improper list, because its second argument is bitstring().
________________________________________________________________________________
done (warnings were emitted)
Halting VM with exit status 2
kianmeng
commented
Jan 2, 2025
Comment on lines
-5
to
+7
| pull_request: | ||
| branches: | ||
| - main | ||
| pull_request: |
There was a problem hiding this comment.
Remove the duplicate check from 26 to 13 by limiting it to pull request branch branch only instead of adding main branch as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of changes: