Escape single-lined description in SDL #968
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
I got a pretty strange error while generating types for typescript out of schema SDL. I have switched from rendering with https://github.com/maartenvanvliet/absinthe_sdl to
Absinthe.Schema.to_sdl
. It turned out I had a macro enum definition like this:The type generator complained about duplicated values in enum. When I took a closer look at generated SDL it looked like:
Which, after stripping descriptions, is:
I got into GraphQL specs for strings: http://spec.graphql.org/June2018/#sec-String-Value
It seems some characters need to be escaped in a single line description string.