-
Notifications
You must be signed in to change notification settings - Fork 529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for repeatable directives #999
Add support for repeatable directives #999
Conversation
@maartenvanvliet this is fantastic, thank you! We will probably target this for the 1.6 release which we hope to go ahead with by the end of the year due to the potential for breakage you note. Will review implementation here shortly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks awesome! From my read, it looks like everything is in place & tested.. Nice work!
Followup that adds this to the |
Adds support for repeatable directives as defined by the spec (https://spec.graphql.org/draft/#sec-Type-System.Directives). See graphql/graphql-spec#472 where the RFC was merged for more information.
This PR does several things:
repeatable
keyword for directives in the parserrepeatable
set to falserepeatable
in SDLisRepeatable
to the directive type available for introspectionrepeatable(true|false)
to the schema definition macro's placed under directivenon_null
declarations to closer match the spec, but can be done in a separate PR)In theory this could be a breaking change, i.e. if the built-in directives were applied multiple times to the same field in a document this will now trigger an error.