Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flink to root for aggregate publish #898

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mickjermsurawong-openai
Copy link
Contributor

Summary

  • Include Flink in the root so it can be published with same versions together with all other modules

Why / Goal

  • Currently to publish flink, we have to run a separate sbt publish doesn't include Flink, and we have to run sbt flink/publish separately
  • This is a problem for our internal repo where each release is also versioned with timestamp eg, 0.0.85+openai.20250107.215212; separate flink publish has a separate timestamp and it couldn't find it's online/aggregator dependency of the same timestamp

Test Plan

  • Added Unit Tests
  • Covered by existing CI
  • Integration tested

Checklist

  • Documentation update

Reviewers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants