Mavericks Extensions argsOrNull

[sanogueralorenzo]

Adding Mavericks Extensions argsOrNull which can be useful for those cases where you have an optional argument that might be sent or not.

As an example, imagine a shared screen / flow from different entry points. While this can be fixed in multiple ways in the client's code having an explicit enum that represents null / empty / none it ends up being more code which ultimately represents the same thing (although this introduces the option of nullable arguments which can also be seen as a downside)

Thoughts?

[codecov]

Codecov Report

Merging #639 (a9178c1) into main (f44e85b) will decrease coverage by 5.62%.
The diff coverage is 11.01%.

❗ Current head a9178c1 differs from pull request most recent head cde1959. Consider uploading reports for the commit cde1959 to get more accurate results

@@            Coverage Diff             @@
##             main     #639      +/-   ##
==========================================
- Coverage   55.06%   49.43%   -5.63%     
==========================================
  Files          53       54       +1     
  Lines        2508     2846     +338     
  Branches      326      338      +12     
==========================================
+ Hits         1381     1407      +26     
- Misses        976     1284     +308     
- Partials      151      155       +4     

Impacted Files	Coverage Δ
.../airbnb/mvrx/compose/MavericksComposeExtensions.kt	0.00% <ø> (ø)
.../airbnb/mvrx/hilt/HiltMavericksViewModelFactory.kt	18.18% <0.00%> (ø)
...main/kotlin/com/airbnb/mvrx/mocking/MockBuilder.kt	22.01% <0.00%> (-11.73%)	⬇️
...main/kotlin/com/airbnb/mvrx/MavericksExtensions.kt	11.76% <50.00%> (+3.58%)	⬆️
...tlin/com/airbnb/mvrx/MavericksViewModelProvider.kt	88.88% <80.00%> (+0.17%)	⬆️
...tlin/com/airbnb/mvrx/mocking/KotlinReflectUtils.kt	66.66% <81.25%> (+8.04%)	⬆️
...otlin/com/airbnb/mvrx/MavericksMutabilityHelper.kt	78.94% <100.00%> (+1.16%)	⬆️
.../main/kotlin/com/airbnb/mvrx/MavericksViewModel.kt	60.71% <100.00%> (ø)
...rx/src/main/kotlin/com/airbnb/mvrx/PersistState.kt	79.16% <100.00%> (-1.10%)	⬇️
...com/airbnb/mvrx/MavericksViewModelConfigFactory.kt	73.68% <0.00%> (ø)
... and 2 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed755e3...cde1959. Read the comment docs.

[gpeal]

@elihart This seems like a reasonable addition to me. Wdyt?

[gpeal]

Suggested change

	* `private val listingId by argsOrNull<MyArgs?>()`
	* `private val listingId: MyArgs? by argsOrNull()`

Can you update the doc above, too?

[gpeal]

Suggested change

	fun <V : Any> argsOrNull() = object : ReadOnlyProperty<Fragment, V?> {
	fun <V> argsOrNull() = object : ReadOnlyProperty<Fragment, V?> {

I think you can safely emit the type narrowing since the return type is nullable.

[sanogueralorenzo]

@elihart what do you think of by argsOrNull?

[elihart]

sure, seems helpful. only comment is that it would be nice to have a test

[sanogueralorenzo]

Sounds good @elihart added tests cde1959

[elihart]

Thanks!