Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blog Page Navigation Breaks Widens Mobile Layout #2841

Closed
2 tasks done
imsi32 opened this issue Nov 16, 2024 · 2 comments · Fixed by #2846
Closed
2 tasks done

Blog Page Navigation Breaks Widens Mobile Layout #2841

imsi32 opened this issue Nov 16, 2024 · 2 comments · Fixed by #2846

Comments

@imsi32
Copy link
Contributor

imsi32 commented Nov 16, 2024

Have you checked that your issue isn't already filed?

  • I read through FAQ and searched through the past issues, none of which addressed my issue.
  • Yes, I have checked that this issue isn't already filed.

Bug description

Blog page navigation breaks widens mobile layout as it does not fit in.

How to reproduce the bug

  1. Go to https://alshedivat.github.io/al-folio/blog/ in small screen.
  2. You will be able to slide to right.

Error messages and logs

The error message you got, with the full traceback if available. Please paste it between these triple backticks.

What operating system are you using?

Not applicable (e.g. you're using GitHub Pages or other hosting)

Where are you seeing the problem on?

Deployed site

More info

blog-page-navigation-issue.mp4
@imsi32
Copy link
Contributor Author

imsi32 commented Nov 19, 2024

I am neither front-end developer nor designer but I find following adjustments which fixes the until 320px width without breaking main logic.

  • Changing "Newer" and "Older" to arrows "<" and ">" in _includes/pagination.liquid.
  • I couldn't find where it takes from but changing padding: .75rem 1.15rem in bootsrap.min.css in
.pagination-lg .page-link {
  padding: .75rem 1.5rem;
  font-size: 1.25rem;
  line-height: 1.5;
}

Images:
desktop
width320

@george-gca
Copy link
Collaborator

You can add these css properties in _sass/_base.scss, since it is loaded after mdb and bootstrap here

<link rel="stylesheet" href="{{ '/assets/css/main.css' | relative_url | bust_css_cache }}">

it will override these values. If this works fine, can you send a PR for this?

imsi32 added a commit to imsi32/al-folio that referenced this issue Nov 19, 2024
imsi32 added a commit to imsi32/al-folio that referenced this issue Nov 19, 2024
george-gca pushed a commit that referenced this issue Nov 19, 2024
I tested on my Github page and it worked correctly. Then, copied here. 

Issue: Blog page navigation extends layout of the page in small screens.
Fixes: #2841
jinningwang pushed a commit to jinningwang/jinningwang.github.io that referenced this issue Dec 2, 2024
I tested on my Github page and it worked correctly. Then, copied here. 

Issue: Blog page navigation extends layout of the page in small screens.
Fixes: alshedivat#2841
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants