Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH36 fix skip bug #37

Merged
merged 2 commits into from
Jun 12, 2024
Merged

Conversation

larmitage-bjss
Copy link
Contributor

To fix #36

Assumed the intention was for the overwrite option to take priority - if overwrite is set to true then skip is set to false

Updated descriptions of inputs to make this clearer

@andrewthetechie
Copy link
Owner

@all-contributors please add @larmitage-bjss for code and bug reports

Copy link
Contributor

@andrewthetechie

I've put up a pull request to add @larmitage-bjss! 🎉

@andrewthetechie
Copy link
Owner

@larmitage-bjss thank you very much for finding and fixing this bug.

@andrewthetechie andrewthetechie merged commit b1a6c61 into andrewthetechie:main Jun 12, 2024
2 checks passed
@larmitage-bjss
Copy link
Contributor Author

Thanks very much for the speedy response!

@andrewthetechie
Copy link
Owner

@larmitage-bjss 1.3.2 is released.

Your timing was perfect on filing this issue, I was just sitting down with my morning coffee :)

@larmitage-bjss larmitage-bjss deleted the GH36-fix-skip-bug branch June 13, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Skip option is always set to the overwrite option
2 participants