-
-
Notifications
You must be signed in to change notification settings - Fork 23.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reorganize docs in readme #2242
base: master
Are you sure you want to change the base?
Conversation
@mezzode is attempting to deploy a commit to the github readme stats Team on Vercel. A member of the Team first needs to authorize it. |
@mezzode Thanks a lot for this pull request it improves the README.md. The only thing that I would change is to keep the themes section. I think if we collapse the theme section by default, we will get many discussion posts from people on how to customize the themes. Further, maybe we can use the 👀 icon before show examples. I do this in the rest of the documentation since many people are unaware of the collapsable markdown option introduced somewhere last year, and 👀 draws their attention. Nevertheless, I already attached the |
Codecov ReportBase: 96.79% // Head: 96.79% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #2242 +/- ##
==========================================
- Coverage 96.79% 96.79% -0.01%
==========================================
Files 22 22
Lines 3836 3835 -1
Branches 328 328
==========================================
- Hits 3713 3712 -1
Misses 121 121
Partials 2 2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
e437c4d
to
12317f3
Compare
12317f3
to
0a27356
Compare
@anuraghazra I think this is a significant improvement of the documentation. 🚀 Can we please merge this? |
86aafe8
to
8bc69e7
Compare
#### Hiding individual stats | ||
|
||
<details> | ||
<summary>:eyes: Show example</summary> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add a new line after every <summary> that way the content will look more readable.
Amazing restructure @mezzode! Thanks for the PR. Although now I wonder what will happen to the translated docs 😆 TBH I find them hard to maintain and doesn't add much value to the overall project other than welcoming new people to contribute to the translation docs. |
I gave up on the non-card-related translations a long time ago since I got overwhelmed by maintaining them 😅 (I'm not a polyglot). I was still hoping to put the card translations into Crowdin and write a small github action that uses the Google translation API to translate the README using the Google translate API👌(see #2053). Maybe there are already existing solutions that do this, or Crowdin got updated to be able to do this automatically. 🤔 |
Resolves #2236. Moves options docs into the sections for the cards they're for and streamlines readme so detailed examples are collapsed by default.