Fix clippy complaints #6573
Merged
Fix clippy complaints #6573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
parquet
alamb
reviewed
Oct 16, 2024
| @@ -15,32 +15,32 @@ | |||
| // specific language governing permissions and limitations | |||
| // under the License. | |||
|
|
|||
| //! Rle/Bit-Packing Hybrid Encoding | |||
mbrobbel
approved these changes
Oct 16, 2024
alamb
reviewed
Oct 16, 2024
There was a problem hiding this comment.
Thank you @itsjunetime -- most of these changes look like very nice improvements 👌
I think we just need to get CI passing and it will be good to go
arrow-schema/src/ffi.rs
Outdated
| @@ -336,7 +336,7 @@ impl FFI_ArrowSchema { | |||
| Ok(HashMap::new()) | |||
| } else { | |||
| let mut pos = 0; | |||
| let buffer: *const u8 = self.metadata as *const u8; | |||
| let buffer: *const u8 = self.metadata; | |||
There was a problem hiding this comment.
this appears to not compile on CI 🤔
e.g. https://github.com/apache/arrow-rs/actions/runs/11370592216/job/31636347622?pr=6573
Run cargo test -p arrow-data --all-features
Compiling bitflags v2.6.0
Compiling arrow-schema v53.1.0 (/__w/arrow-rs/arrow-rs/arrow-schema)
error[E0308]: mismatched types
--> arrow-schema/src/ffi.rs:339:3[7](https://github.com/apache/arrow-rs/actions/runs/11370592216/job/31636347622?pr=6573#step:6:8)
|
339 | let buffer: *const u[8](https://github.com/apache/arrow-rs/actions/runs/11370592216/job/31636347622?pr=6573#step:6:9) = self.metadata;
| --------- ^^^^^^^^^^^^^ expected `*const u8`, found `*const i8`
| |
| expected due to this
|
= note: expected raw pointer `*const u8`
found raw pointer `*const i8`
For more information about this error, try `rustc --explain E0308`.
error: could not compile `arrow-schema` (lib) due to 1 previous error
Error: Process completed with exit code [10](https://github.com/apache/arrow-rs/actions/runs/11370592216/job/31636347622?pr=6573#step:6:11)1.
There was a problem hiding this comment.
Just fixed - clippy was complaining about casting to the same type, but I had foolishly forgotten what I'd just learned about c_char = (i8|u8) so I removed the cast. It's now a cast with an #[allow()]
Dandandan
reviewed
Oct 17, 2024
| @@ -26,7 +26,7 @@ pub fn round_upto_multiple_of_64(num: usize) -> usize { | |||
| /// Returns the nearest multiple of `factor` that is `>=` than `num`. Here `factor` must | |||
| /// be a power of 2. | |||
| pub fn round_upto_power_of_2(num: usize, factor: usize) -> usize { | |||
| debug_assert!(factor > 0 && (factor & (factor - 1)) == 0); | |||
| debug_assert!(factor > 0 && factor.is_power_of_two()); | |||
itsjunetime
force-pushed
the
june/fix_clippy_complaints
branch
from
2fa0ead to
773997b
Compare
alamb
approved these changes
Oct 19, 2024
There was a problem hiding this comment.
Thank you @itsjunetime -- this looks great to me
also thank you @Dandandan and @mbrobbel for the review
|
I merged up from master to hopefully get a clean CI run |
mbrobbel
approved these changes
Oct 21, 2024
|
🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
None
Rationale for this change
When running
cargo clippyon this project with the latest nightly (and even with stable), it raises a lot of issues. This just goes through each of those issues and fixes them.What changes are included in this PR?
Small changes to fix the issues clippy was complaining about. Most of this is removing explicit lifetimes where unnecessary, but there are also a few instances of fixing doc comments and other small things.
Are there any user-facing changes?
Some doc comments that previously wouldn't be appearing correctly in docs.rs will now show up where expected.