Add limited support for dictionary builders in make_builders for stru…
#6593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ct array builders
kszlim
commented
Oct 20, 2024
| match &**value_type { | ||
| DataType::Utf8 => { | ||
| let dict_builder: StringDictionaryBuilder<Int32Type> = | ||
| StringDictionaryBuilder::with_capacity(capacity, 32, 1024); |
There was a problem hiding this comment.
not sure about good default capacity values, @tustvold go ahead and edit them if you don't like them.
There was a problem hiding this comment.
Looks to me like the standard capacity is 256 for values in https://github.com/apache/arrow-rs/blob/20433530e7f60fa9ff45ae7c51c3e5ab27c7a2d0/arrow-array/src/array/dictionary_array.rs#L659-L658
I'll push a commit to match that.
|
Pretty sure the integration test failure is unrelated, can someone re-run? |
3 tasks
|
CI should be clean after a merge up from main |
alamb
changed the title
make_builders for stru…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ct array builders
Which issue does this PR close?
Closes #6589
Rationale for this change
Makes make_builders more useful in general
What changes are included in this PR?
Adds branches to
make_buildersto support Int32 keys and string + binary valuesAre there any user-facing changes?
No api changes, but a larger % of fields will now work with
make_builders