Add support for building FixedSizeListBuilder in struct_builder's mak… #6595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please feel free to change anything required to merge this in |
3 tasks
tustvold
reviewed
Oct 20, 2024
| @@ -253,6 +253,13 @@ pub fn make_builder(datatype: &DataType, capacity: usize) -> Box<dyn ArrayBuilde | |||
| let builder = make_builder(field.data_type(), capacity); | |||
| Box::new(LargeListBuilder::with_capacity(builder, capacity).with_field(field.clone())) | |||
| } | |||
| DataType::FixedSizeList(field, size) => { | |||
| let builder = make_builder(field.data_type(), capacity); | |||
There was a problem hiding this comment.
I think this should be capacity*size
There was a problem hiding this comment.
Hmm are you sure, @tustvold I followed the pattern for the above Listbuilder, seems like either that's wrong too or this is right.
There was a problem hiding this comment.
ListBuilder doesn't have a fixed size
Sounds good, I was following the pattern in the rest of the code, it didn't seem like there were tests for every builder type. |
|
@tustvold made your suggested changes |
alamb
approved these changes
Oct 21, 2024
| let size: usize = size.try_into().unwrap(); | ||
| capacity * size | ||
| }; | ||
| let builder = make_builder(field.data_type(), values_builder_capacity); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…e_builders
Which issue does this PR close?
Closes #6594 .
Rationale for this change
Makees
make_buildersmore flexible/usefulWhat changes are included in this PR?
Adds support for FixedSizeList builders in make_builders
Are there any user-facing changes?
No API changes, but users will be able to successfully construct FixedSizeList builders.