Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove mockito from dependencyManagement #570

Closed
wants to merge 1 commit into from

Conversation

raboof
Copy link
Member

@raboof raboof commented Jan 3, 2025

Since some Commons projects still support Java 8 and others don't, it doesn't make much sense for the parent pom to specify a version (since projects on Java 8 will want to stick with 4.x while others will want to move to 5.x)

Thanks for your contribution to Apache Commons! Your help is appreciated!

Before you push a pull request, review this list:

  • Read the contribution guidelines for this project.
  • Run a successful build using the default Maven goal with mvn; that's mvn on the command line by itself.
  • Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. This may not always be possible but is a best-practice.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Each commit in the pull request should have a meaningful subject line and body. Note that commits might be squashed by a maintainer on merge.

Since some Commons projects still support Java 8 and others
don't, it doesn't make much sense for the parent pom to
specify a version (since projects on Java 8 will want to
stick with 4.x while others will want to move to 5.x)
@garydgregory
Copy link
Member

@raboof
I think we should keep it as a baseline; we are in the same situation with Checkstyle.

@raboof raboof closed this Jan 3, 2025
@raboof raboof mentioned this pull request Jan 3, 2025
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants