Add an option for ignoring tombstone records while a get on VersionedKeyValueStore #18398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Another option would be to permit to make an "actualDelete" in segments to delete record in store instead of putting a tombstone. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added an option to the method
org.apache.kafka.streams.state.VersionedKeyValueStore.get(K, long, boolean)to permit to find a record, while ignoring all tombstones records.The find will search for previous record if we have a tombstone, and for the "validTo" field, the find method will search the first following "valid" record (ie. not a tombstone).
I've added 3 tests, 2 for RocksDBVersionedStore and 1 for PartiallyDeserializedSegment
Committer Checklist (excluded from commit message)