KAFKA-18432: Remove unused code from AutoTopicCreationManager #18438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
triage
chia7712
reviewed
Jan 8, 2025
| controller, groupCoordinator, txnCoordinator, shareCoordinator) | ||
| } | ||
| } | ||
|
|
||
| class DefaultAutoTopicCreationManager( | ||
| config: KafkaConfig, | ||
| channelManager: Option[NodeToControllerChannelManager], |
There was a problem hiding this comment.
the wrap of Option is unnecessary, right?
There was a problem hiding this comment.
Exactly, the param is required.
The `channelManager` parameter is now required and no longer optional.
chia7712
approved these changes
Jan 8, 2025
chia7712
pushed a commit
that referenced
this pull request
Jan 8, 2025
Reviewers: Chia-Ping Tsai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://issues.apache.org/jira/browse/KAFKA-18432
Committer Checklist (excluded from commit message)