Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NPE in handleMethodException method of apm-jdk-threadpool-plugin. #681

Merged
merged 1 commit into from
Apr 18, 2024
Merged

Fix NPE in handleMethodException method of apm-jdk-threadpool-plugin. #681

merged 1 commit into from
Apr 18, 2024

Conversation

ForrestWang123
Copy link
Contributor

Fix NPE in handleMethodException method of apm-jdk-threadpool-plugin

  • Add a unit test to verify that the fix works.
  • Explain briefly why the bug exists and how to fix it.
  • If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #12128.
  • Update the CHANGES log.

@wu-sheng wu-sheng self-requested a review April 18, 2024 11:40
@wu-sheng wu-sheng added this to the 9.2.0 milestone Apr 18, 2024
@wu-sheng wu-sheng added bug Something isn't working plugin labels Apr 18, 2024
@wu-sheng wu-sheng mentioned this pull request Apr 18, 2024
Closed
3 tasks
@wu-sheng wu-sheng merged commit ec30b5f into apache:main Apr 18, 2024
188 checks passed
ForrestWang123 pushed a commit to ForrestWang123/skywalking-java that referenced this pull request Apr 18, 2024
Fix NPE in handleMethodException method of apm-jdk-threadpool-plugin. (…
a452c42 
…apache#681)
wu-sheng pushed a commit that referenced this pull request Apr 19, 2024
@ForrestWang123
Fix NPE in handleMethodException method of apm-jdk-threadpool-plugin. (…
1a01047 
…#681) (#682)

Co-authored-by: forrestwang <[email protected]>
liweiyuan pushed a commit to liweiyuan/skywalking-java that referenced this pull request Apr 24, 2024
@ForrestWang123 @liweiyuan
Fix NPE in handleMethodException method of apm-jdk-threadpool-plugin. (…
4569ff0 
…apache#681)

Co-authored-by: forrestwang <[email protected]>
liweiyuan pushed a commit to liweiyuan/skywalking-java that referenced this pull request Apr 24, 2024
@ForrestWang123 @liweiyuan
Fix NPE in handleMethodException method of apm-jdk-threadpool-plugin. (…
3f21845 
…apache#681) (apache#682)

Co-authored-by: forrestwang <[email protected]>
@wu-sheng wu-sheng modified the milestones: 9.2.0, 9.3.0 Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wu-sheng wu-sheng wu-sheng approved these changes

Assignees
No one assigned
Labels
bug Something isn't working plugin
Projects
None yet
Milestone
9.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ForrestWang123 @wu-sheng