fix: ID param for DELETE ssh_tunnel endpoint #27130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geido
added
the
risk:breaking-change
…o/ch78628/fix-delete-ssh-endpoint
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #27130 +/- ##
==========================================
+ Coverage 67.15% 69.57% +2.42%
==========================================
Files 1902 1894 -8
Lines 74441 74072 -369
Branches 8306 8191 -115
==========================================
+ Hits 49994 51539 +1545
+ Misses 22393 20494 -1899
+ Partials 2054 2039 -15
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Co-authored-by: Michael S. Molina <[email protected]>
eschutho
reviewed
Feb 15, 2024
| @@ -1447,6 +1447,7 @@ def validate_parameters(self) -> FlaskResponse: | |||
| @expose("/<int:pk>/ssh_tunnel/", methods=("DELETE",)) | |||
| @protect() | |||
| @statsd_metrics | |||
| @deprecated(deprecated_in="4.0") | |||
There was a problem hiding this comment.
@geido doesn't this mean that we'll be removing this endpoint eventually?
There was a problem hiding this comment.
No. It means that the endpoint was deprecated in 4.0 to be removed in a future version. Possibly 5.0.
There was a problem hiding this comment.
Yeah the idea is indeed to remove it in a future version
grvoicu
added a commit
to grvoicu/superset
that referenced
this pull request
Feb 20, 2024
…-to-the-embedded-dashboard * master: (1182 commits) fix(ci): mypy pre-commit issues (apache#27161) feat(Alerts and Reports): Modal redesign (apache#26202) refactor: Migrate ErrorBoundary to typescript (apache#27143) chore(tests): Remove unnecessary explicit Flask-SQLAlchemy session expunges (apache#27136) fix(plugins): Apply dashboard filters to comparison query in BigNumber with Time Comparison chart (apache#27138) fix: Duplicated toast messages (apache#27135) docs: add Geotab to users list (apache#27134) fix: Plain error message when visiting a dashboard via permalink without permissions (apache#27132) fix: ID param for DELETE ssh_tunnel endpoint (apache#27130) chore(hail mary): Update package-lock.json via npm-audit-fix (apache#26693) chore: lower cryptography min version to 41.0.2 (apache#27129) docs(miscellaneous): Export Datasoruces: export datasources exports to ZIP (apache#27120) fix(pivot-table-v2): Added forgotten translation pivot table v2 (apache#22840) fix: RLS modal overflow (apache#27128) refactor: Updates some database columns to MediumText (apache#27119) fix: gevent upgrade to 23.9.1 (apache#27112) fix: removes old deprecated sqllab endpoints (apache#27117) feat(storybook): Co-habitating/Upgrading Storybooks to v7 (dependency madness ensues) (apache#26907) fix: bump grpcio, urllib3 and paramiko (apache#27124) chore(internet_port): added new ports and removed unnecessary string class (apache#27078) ...
sfirke
pushed a commit
to sfirke/superset
that referenced
this pull request
Mar 22, 2024
Co-authored-by: Michael S. Molina <[email protected]>
mistercrunch
added
🏷️ bot
vinothkumar66
pushed a commit
to vinothkumar66/superset
that referenced
this pull request
Nov 11, 2024
Co-authored-by: Michael S. Molina <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
The DELETE
database/{id}/ssh_tunnelendpoint was incorrectly expecting an SSH Tunnel ID rather than the Database ID. This PR fixes it.It deprecates the endpoint as the ssh_tunnel should be a property of the database and should be updated according to the database update endpoint.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N.A.
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION