Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(function): add custom functions documentation for AWS Amplify-backend #8176

Merged

Conversation

MarlonJD
Copy link
Contributor

… Gen 2 @aws-amplify/amplify-backend/1602

Description of changes:

Add custom runtime documents, it's required for #1602

Related GitHub issue

#1543, #1486

Instructions

Which product(s) are affected by this PR (if applicable)?

  • amplify-backend
  • amplify-ui
  • amplify-studio
  • amplify-hosting
  • amplify-libraries

Which platform(s) are affected by this PR (if applicable)?

  • JS
  • Swift
  • Android
  • Flutter
  • React Native

Please add the product(s)/platform(s) affected to the PR title
amplify-backend

Checks

When this PR is ready to merge, please check the box below

  • Ready to merge

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Member

@sobolk sobolk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left two comments around docker and go. But I suggest to wait until @josefaidt gets a chance to review this before making changes.

Copy link
Contributor

@josefaidt josefaidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @MarlonJD thank you for taking the time to write this up!! I left a few comments to adjust some of the language used but overall this looks great!

…orrecting capitalization and enhancing clarity
@MarlonJD
Copy link
Contributor Author

MarlonJD commented Jan 7, 2025

Hi @josefaidt,
Thank you so much for your kind words and for taking the time to review this!
I really appreciate your feedback and have made adjustments based on your comments to refine the language. Please let me know if there’s anything else you'd like to tweak or improve further.

… code examples in custom functions documentation
@MarlonJD MarlonJD requested a review from josefaidt January 7, 2025 18:55
josefaidt
josefaidt previously approved these changes Jan 7, 2025
sobolk
sobolk previously approved these changes Jan 7, 2025
@MarlonJD MarlonJD dismissed stale reviews from sobolk and josefaidt via 4989b85 January 8, 2025 15:57
sobolk
sobolk previously approved these changes Jan 8, 2025
josefaidt
josefaidt previously approved these changes Jan 8, 2025
@MarlonJD MarlonJD dismissed stale reviews from josefaidt and sobolk via 1ca323f January 8, 2025 16:26
@josefaidt josefaidt merged commit 3418e98 into aws-amplify:main Jan 8, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants