chore(bindings): feature gate network tests #4907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dougch
approved these changes
Nov 19, 2024
goatgoose
approved these changes
Nov 20, 2024
goatgoose
approved these changes
Nov 22, 2024
dougch
approved these changes
Nov 22, 2024
| TestCase::new("https://www.facebook.com", &[302]), | ||
| // 2024-11-21: Microsoft had been consistently returning a 302. It then started | ||
| // returning 403 codes in CI, but was returning 200 codes when run locally. | ||
| TestCase::new("https://www.microsoft.com", &[200, 302, 403]), |
There was a problem hiding this comment.
oof, but that is the behavior...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Currently network tests are being run more than they should be, because many of our CI jobs use
cargo test --all-features. This is a problem because itThis PR adjusts the feature flag so that the network tests aren't accidentally enabled with those invocations.
This PR also updated the expected results to account for variance that we have been seeing in CI.
Testing:
The network tests can be seen in the intended CI logs (and not in the other logs)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.