Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commented out line 118 #51

Merged
merged 2 commits into from
Jul 12, 2024
Merged

Commented out line 118 #51

merged 2 commits into from
Jul 12, 2024

Conversation

thisiszeev
Copy link
Contributor

@thisiszeev thisiszeev commented Jul 10, 2024

This ensures remains inline. However

 
will still render as a separate block.

Summary by Sourcery

Adjusted the handling of tags in the HTML parser to ensure inline rendering, while maintaining block rendering for

.

  • Bug Fixes:
    • Commented out Tag.CODE in the list of tags to ensure remains inline while
       renders as a separate block.

This ensures <code> </code> remains inline. However <pre><code> </code></pre> will still render as a separate block.
Copy link

sourcery-ai bot commented Jul 10, 2024

Reviewer's Guide by Sourcery

This pull request comments out a specific line in the tkhtmlview/html_parser.py file to ensure that <code> tags remain inline while <pre><code> tags continue to render as separate blocks.

File-Level Changes

Files Changes
tkhtmlview/html_parser.py Commented out Tag.CODE to modify the rendering behavior of <code> tags.

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @thisiszeev - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

Line 649 was inserting a trailing space after a closing tag. This is creating spaces where there shouldn't be spaces. I have removed the space.
@bauripalash bauripalash merged commit ee36684 into bauripalash:main Jul 12, 2024
@bauripalash
Copy link
Owner

@thisiszeev, thanks. I have merged your fix, as well as added an inline code block example in example.py

@bauripalash
Copy link
Owner

@thisiszeev I released the update to PyPI and GitHub releases.https://pypi.org/project/tkhtmlview/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants