feat: Improve web site accessibility/legibility #2080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svenberkvens
reviewed
Dec 9, 2023
dz4k
approved these changes
Dec 9, 2023
|
Not sure the reasoning why, but @1cg likes quirks mode... |
Interesting, you can remove the doctype then! |
alexpetros
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please describe what changes you made, and why you feel they are necessary. Make sure to include
code examples, where applicable.
This PR improves web site accessibility/legibility by adding alt attributes where needed, changing colors to improve contrast, changing the fake links in the logo to spans and adding an edited highlighting theme which makes the background color darker and comments brighter.
It also adds doctype and a meta description tag for SEO.
Feel free to edit the colors if needed.
Before:
After:
Lighthouse before:
Lighthouse after (locally served):
Testing
Please explain how you tested this change manually, and, if applicable, what new tests you added. If
you're making a change to just the website, you can omit this section.
No tests added.
Checklist
masterfor website changes,devforsource changes)
approved via an issue
npm run test) and verified that it succeeded