[2.0] Improve extension registration logic #2505
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR improves htmx extension registration by allowing extensions to contribute to the selector used in
findElementsToProcess
. This change makes extension initialization much simpler since it can just inform htmx about what elements it want to process without the need to look for them in processed fragments. This change nicely avoids double processing issue since deduplication logic is implemeted byquerySelectorAll
Corresponding issue: bigskysoftware/htmx-extensions#16
Testing
Since 2.0 repo has no extension, tests for this behavior are added to corresponding extension directory over at bigskysoftware/htmx-extensions
see bigskysoftware/htmx-extensions#18
Checklist
master
for website changes,dev
forsource changes)
approved via an issue
npm run test
) and verified that it succeeded