Fix relative URLs to be considered as sameHost #3113
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
when the URL function is not used for the URL validation and the path is a relative URL
startsWith(path, document.location.origin)
would returnfalse
.Since we can guarantee that relative URLs must be on the same host, I wanted to move the check earlier up the code and return early but unsure if it is a desired pattern.
Corresponding issue:
Testing
We had a site that was working normally but somehow a GoogleTagManager JS that we have no control over was removing the native
URL
function from the browser (which is wild)Was implementing a workaround on our end but I thought this might break on IE11 right now if URL is really not available.
Checklist
master
for website changes,dev
forsource changes)
approved via an issue
npm run test
) and verified that it succeeded