Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added pass-through of New()'s ss.SetServers()'s error to New() for easier debugging #83

Closed
wants to merge 1 commit into from

Conversation

ricardbejarano
Copy link

This PR fixes #68

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

Copy link

@Linkerist Linkerist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Emm... It throw error in the early stages indeed, but it change API of this client. Well, as a developer, I have a positive attitude towards this since we want to get specific resolve error, but I don't know what maintainers and others think.

@ricardbejarano
Copy link
Author

Closing after >2y of inactivity and because I won't sign the CLA.

@ricardbejarano
Copy link
Author

I waive all my rights with regard to the contributed code and release it to the public domain, if that allows the code to be merged without me signing the CLA.

mikelolasagasti added a commit to mikelolasagasti/gomemcache that referenced this pull request Mar 14, 2024
Return ss.SetServers()'s error to make debugging easier.

Updates bradfitz#83

Closes bradfitz#63

Signed-off-by: Mikel Olasagasti Uranga <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Why doesn't function New(server ...string) return err?
3 participants