[ENH]: parallelize applying materialized log to segment writers #3359
+218
−216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Dec 27, 2024
1 task
codetheweb
commented
Dec 27, 2024
| @@ -280,7 +280,7 @@ impl CompactOrchestrator { | |||
| None => return, | |||
| }; | |||
|
|
|||
| self.num_write_tasks = partitions.len() as i32; | |||
| self.num_write_tasks = partitions.len() as i32 * 3; | |||
There was a problem hiding this comment.
this is removed in the next PR in this stack
1 task
HammadB
reviewed
Jan 2, 2025
| &self, | ||
| record_segment_reader: &Option<RecordSegmentReader>, | ||
| materialized_chunk: &MaterializeLogsResult, | ||
| ) -> Result<(), ApplyMaterializedLogError>; | ||
| ) -> impl Future<Output = Result<(), ApplyMaterializedLogError>> + Send; |
There was a problem hiding this comment.
Interesting, the impl can still be async fn apply_materialized_log_chunk and this works? Is this because async is just syntactic sugar for that?
HammadB
approved these changes
Jan 2, 2025
codetheweb
force-pushed
the
feat-materialize-operator-2
branch
from
b25da8b to
88c8462
Compare
codetheweb
force-pushed
the
perf-parallelize-applying-log-2
branch
from
2e9a2e0 to
d09d690
Compare
codetheweb
changed the base branch from
feat-materialize-operator-2
to
graphite-base/3359
codetheweb
force-pushed
the
perf-parallelize-applying-log-2
branch
from
d09d690 to
23ef45e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Applies log updates to segment types in parallel rather than sequentially:
Pipelining flushes to S3/applying to blockfile will be in the next PR in this stack.
Test plan
How are these changes tested?
pytestfor python,yarn testfor js,cargo testfor rustAlso tested with SciDocs.
Documentation Changes
Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?
n/a