Add orgUserHasExistingUser parameters to org invite #4827
Merged
+41
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefan0xC
reviewed
Aug 8, 2024
Timshel
force-pushed
the
feature/org-invite
branch
from
7ac3883 to
5980ce3
Compare
BlackDex
requested changes
Aug 9, 2024
Timshel
force-pushed
the
feature/org-invite
branch
2 times, most recently
from
15c1f7c to
9408057
Compare
dfunkt
reviewed
Aug 9, 2024
Timshel
force-pushed
the
feature/org-invite
branch
from
9408057 to
b8e856f
Compare
Timshel
force-pushed
the
feature/org-invite
branch
from
b8e856f to
0cbb47f
Compare
BlackDex
force-pushed
the
feature/org-invite
branch
from
0cbb47f to
4b28773
Compare
BlackDex
approved these changes
Aug 30, 2024
|
Nice, works well. |
dani-garcia
approved these changes
Sep 1, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the new web-vault
web-v2024.6.2the organization invitation logic was rewritten (had a look since organization invitation is now working even with sso 🎉).Discovered that there were additional parameters that were not used such as
orgUserHasExistingUserwhich allows to control if the user is redirected to the create account or login page (Cf web-v2024.6.2/accept-organization.component.ts, but this already existed before).The additional
orgSsoIdentifierparameter could then be added to the SSO PR.