Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(query): function about convert_timezone #16177 #16181

Merged
merged 64 commits into from
Nov 5, 2024

Conversation

florann
Copy link
Contributor

@florann florann commented Aug 4, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

The goal was to add a function that allow to convert a timestamp, with a timezone or not, to a specific timezone

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@florann florann changed the title Feature: function about convert_timezone #16177 feat(query): function about convert_timezone #16177 Aug 4, 2024
@github-actions github-actions bot added the pr-feature this PR introduces a new feature to the codebase label Aug 4, 2024
@b41sh
Copy link
Member

b41sh commented Aug 5, 2024

@florann
Copy link
Contributor Author

florann commented Aug 5, 2024

Okay with a lot of struggling, it only remain me to develop the 3 arguments function and to add check on NULL value :)

What an hard first task in Rust

src/query/functions/src/scalars/datetime.rs Outdated Show resolved Hide resolved
src/query/functions/src/scalars/datetime.rs Outdated Show resolved Hide resolved
src/query/functions/src/scalars/datetime.rs Outdated Show resolved Hide resolved
@florann
Copy link
Contributor Author

florann commented Aug 8, 2024

Hello !

@b41sh, I correct all the points you previously mentioned.

:^)

I'll try to watch a bit in depth how unit test configuration is working otherwise I'll ask for your help

@florann
Copy link
Contributor Author

florann commented Aug 9, 2024

Okay, so I really don't get how I need to set up my unit test.
Even refering to the function to_timestamp isn't helping me

src/query/functions/src/scalars/datetime.rs Outdated Show resolved Hide resolved
src/query/functions/src/scalars/datetime.rs Outdated Show resolved Hide resolved
src/query/functions/src/scalars/datetime.rs Outdated Show resolved Hide resolved
@b41sh b41sh requested a review from TCeason August 9, 2024 13:45
@TCeason
Copy link
Collaborator

TCeason commented Aug 9, 2024

@b41sh b41sh added this pull request to the merge queue Nov 2, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 2, 2024
@TCeason TCeason added this pull request to the merge queue Nov 5, 2024
Copy link
Collaborator

@TCeason TCeason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for @florann pr. And look forward to keeping an eye on databend in the future

Merged via the queue into databendlabs:main with commit 31b7ceb Nov 5, 2024
74 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: function about convert_timezone
3 participants