Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): flaky test #16207

Merged
merged 2 commits into from
Aug 20, 2024
Merged

chore(ci): flaky test #16207

merged 2 commits into from
Aug 20, 2024

Conversation

zhyass
Copy link
Member

@zhyass zhyass commented Aug 7, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

  1. Enhanced Error Messaging: Improved the error messages to be more detailed and precise.

  2. Evict Table Cache After Lock Acquisition: Added logic to evict the table cache after acquiring a lock.

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Aug 7, 2024
@zhyass zhyass marked this pull request as draft August 7, 2024 10:15
@zhyass zhyass force-pushed the feature_fix branch 4 times, most recently from d91fafa to d7cf8ec Compare August 9, 2024 02:55
@zhyass zhyass force-pushed the feature_fix branch 4 times, most recently from 624dc17 to edf43b6 Compare August 19, 2024 02:47
@zhyass zhyass marked this pull request as ready for review August 19, 2024 10:18
Copy link
Member

@drmingdrmer drmingdrmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 11 of 11 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @BohuTANG and @dantengsky)

@zhyass zhyass added this pull request to the merge queue Aug 20, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 20, 2024
@BohuTANG BohuTANG merged commit 28670ef into databendlabs:main Aug 20, 2024
70 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-chore this PR only has small changes that no need to record, like coding styles.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants