Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new table option data_retention_period_in_hours #16266

Merged

Conversation

dantengsky
Copy link
Member

@dantengsky dantengsky commented Aug 16, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

Introduces new table option data_retention_period_in_hours, which has a higher priority to session/global level setting of data_retention_period_in_days, if it is set.

The min value of table data_retention_period_in_hours is 1 (hour), the max values of it isconfig.data_retention_time_in_days_max is specified ( or 90 days if not specified in config)

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-feature this PR introduces a new feature to the codebase label Aug 16, 2024
@dantengsky dantengsky marked this pull request as ready for review August 19, 2024 06:17
@dantengsky dantengsky added this pull request to the merge queue Aug 19, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 19, 2024
@dantengsky dantengsky added this pull request to the merge queue Aug 19, 2024
@BohuTANG BohuTANG removed this pull request from the merge queue due to a manual request Aug 19, 2024
@BohuTANG BohuTANG merged commit 0368216 into databendlabs:main Aug 19, 2024
72 checks passed
@sundy-li
Copy link
Member

sundy-li commented Aug 19, 2024

which has a higher priority to session/global level setting of data_retention_period_in_days

Let's just keep config & table option. I think maybe we don't need the setting.

@dantengsky
Copy link
Member Author

Let's just keep config & table option. I think maybe we don't need the setting.

do you mean we no longer need session level retention period settings?

@sundy-li
Copy link
Member

sundy-li commented Aug 19, 2024

Yes, I think keep three with different priority confuses a lot.

@wubx
Copy link
Member

wubx commented Sep 9, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants