Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Use global http client to share the connection pool #16276

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Aug 19, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

Utilize a global request client to share the connection pool. This change can prevent users from creating too many short-lived connections, which could exhaust the entire local port range in extreme cases.

NOTE: this is the default behavior of aws-sdk-sdk and we have already uses the same http client in our DataOperator. This change makes sure that all stage, external location table can use the same client.

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@Xuanwo Xuanwo added the ci-benchmark Benchmark: run all test label Aug 19, 2024
@github-actions github-actions bot added the pr-refactor this PR changes the code base without new features or bugfix label Aug 19, 2024
@Xuanwo Xuanwo changed the title refactor: Use global request client to share the connection pool refactor: Use global http client to share the connection pool Aug 19, 2024
Copy link
Contributor

Docker Image for PR

  • tag: pr-16276-edba3cb-1724062731

note: this image tag is only available for internal use,
please check the internal doc for more details.

@Xuanwo Xuanwo added this pull request to the merge queue Aug 19, 2024
@BohuTANG BohuTANG removed this pull request from the merge queue due to a manual request Aug 19, 2024
@BohuTANG BohuTANG merged commit e14003c into databendlabs:main Aug 19, 2024
93 checks passed
@Xuanwo Xuanwo deleted the global-http-client branch August 19, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-benchmark Benchmark: run all test pr-refactor this PR changes the code base without new features or bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants