refactor: change value of meta-service key DatabaseNameIdent from DatabaseId to Id<DatabaseId>
#16299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
pr-refactor
drmingdrmer
force-pushed
the
113-id-wrapper
branch
from
3119d00 to
ecd5903
Compare
drmingdrmer
force-pushed
the
113-id-wrapper
branch
4 times, most recently
from
2fbb094 to
8841f9a
Compare
…type This will be useful to make `Id<T>` a wrapper type for T to impl `prost::Message` for T.
…DatabaseId` to `Id<DatabaseId>` `Id<DatabaseId>` is a `prost::Message` and can be used directly as a meta-service value thus it unifies get operation to meta-service. For example, `KVPbApi::get_db()` now can be used to get a u64 id value, instead of using `get_u64_value()`.
drmingdrmer
force-pushed
the
113-id-wrapper
branch
from
8841f9a to
61a0c1f
Compare
11 tasks
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
refactor: change value of meta-service key
DatabaseNameIdentfromDatabaseIdtoId<DatabaseId>Id<DatabaseId>is aprost::Messageand can be used directly as ameta-service value thus it unifies get operation to meta-service.
For example,
KVPbApi::get_db()now can be used to get a u64 id value,instead of using
get_u64_value().refactor: make Id more generic so that it can include any kind of Id type
This will be useful to make
Id<T>a wrapper type for T to implprost::Messagefor T.Tests
Type of change
Related Issues
This change is