refactor: add associated type kvapi::Value::KeyType #16320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
pr-refactor
This way the key tyep and the value type becomes one-to-one mapping. The KeyType is used to build a key from a value. For example, `Id<DatabaseId>` is a value, to build a key to load `DatabaseMeta`, it needs a `Tenant` to build the key `TIdent<T>`. Such a `Tenant` can be retrieve from the key of `Id<DatabaseId>`, i.e., `<Id<DatabaseId> as kvapi::Value>::KeyType` refactor: simplify get_data_mask
drmingdrmer
force-pushed
the
119-value-key-type
branch
from
c27eb38 to
d609114
Compare
11 tasks
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
refactor: add associated type kvapi::Value::KeyType
This way the key tyep and the value type becomes one-to-one mapping.
The KeyType is used to build a key from a value.
For example,
Id<DatabaseId>is a value, to build a key to loadDatabaseMeta, it needs aTenantto build the keyTIdent<T>.Such a
Tenantcan be retrieve from the key ofId<DatabaseId>, i.e.,<Id<DatabaseId> as kvapi::Value>::KeyTyperefactor: simplify get_data_mask
Tests
Type of change
Related Issues
This change is