Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(query): explain ast work like explain syntax #16335

Merged
merged 3 commits into from
Aug 27, 2024

Conversation

sundy-li
Copy link
Member

@sundy-li sundy-li commented Aug 27, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

simple ast visitor, make explain ast work like explain syntax

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@sundy-li sundy-li requested a review from andylokandy August 27, 2024 03:19
@github-actions github-actions bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Aug 27, 2024
@sundy-li sundy-li requested a review from b41sh August 27, 2024 03:19
@BohuTANG BohuTANG merged commit f746a4a into databendlabs:main Aug 27, 2024
71 checks passed
@BohuTANG
Copy link
Member

cc@soyeric128 The format of EXPLAIN AST changed after this PR: https://docs.databend.com/sql/sql-commands/explain-cmds/explain-ast, need updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-chore this PR only has small changes that no need to record, like coding styles.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants