Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Catalog Manager API improvements for create and drop operations #16338

Merged
merged 2 commits into from
Aug 28, 2024

Conversation

drmingdrmer
Copy link
Member

@drmingdrmer drmingdrmer commented Aug 27, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

refactor: Catalog Manager API improvements for create and drop operations
  • create now returns the created ID.
  • drop now returns the deleted ID.
  • Removed the use of ErrorCode for Unknown and Exist errors to
    simplify error handling for callers.
  • Adopted a map-like API for the create and drop operations,
    improving usability and consistency.
refactor: Simplify catalog meta API

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Refactoring

Related Issues


This change is Reviewable

@github-actions github-actions bot added the pr-refactor this PR changes the code base without new features or bugfix label Aug 27, 2024
@drmingdrmer drmingdrmer force-pushed the 123-refactor-catalog branch from 02cc73e to aecb92d Compare August 27, 2024 09:54
@drmingdrmer drmingdrmer marked this pull request as ready for review August 27, 2024 12:26
@drmingdrmer drmingdrmer requested a review from Xuanwo August 27, 2024 12:26
@drmingdrmer drmingdrmer force-pushed the 123-refactor-catalog branch from aecb92d to 270409e Compare August 28, 2024 02:23
…ions

- `create` now returns the created ID.
- `drop` now returns the deleted ID.
- Removed the use of `ErrorCode` for `Unknown` and `Exist` errors to
  simplify error handling for callers.
- Adopted a map-like API for the `create` and `drop` operations,
  improving usability and consistency.
@drmingdrmer drmingdrmer force-pushed the 123-refactor-catalog branch from 270409e to 5d5b3c7 Compare August 28, 2024 03:00
@drmingdrmer drmingdrmer merged commit 5a2f841 into databendlabs:main Aug 28, 2024
71 of 72 checks passed
@drmingdrmer drmingdrmer deleted the 123-refactor-catalog branch August 28, 2024 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-refactor this PR changes the code base without new features or bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant