Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(query): reduce hash join memory usage #16359

Merged
merged 10 commits into from
Sep 2, 2024

Conversation

Dousir9
Copy link
Member

@Dousir9 Dousir9 commented Sep 1, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

Reduce hash join memory usage.

Fixes: #16314

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Covered by existing tests.

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Sep 1, 2024
@Dousir9 Dousir9 added the ci-benchmark Benchmark: run all test label Sep 1, 2024
Copy link
Contributor

github-actions bot commented Sep 1, 2024

Docker Image for PR

  • tag: pr-16359-35640b0-1725206419

note: this image tag is only available for internal use,
please check the internal doc for more details.

@Dousir9 Dousir9 marked this pull request as ready for review September 2, 2024 02:43
@dosubot dosubot bot added the size:XXL This PR changes 1000+ lines, ignoring generated files. label Sep 2, 2024
@Dousir9 Dousir9 requested a review from xudong963 September 2, 2024 02:43
@dosubot dosubot bot added A-query Area: databend query pr-refactor this PR changes the code base without new features or bugfix labels Sep 2, 2024
Copy link
Contributor

github-actions bot commented Sep 2, 2024

Docker Image for PR

  • tag: pr-16359-d31c6b3-1725247010

note: this image tag is only available for internal use,
please check the internal doc for more details.

Copy link
Contributor

github-actions bot commented Sep 2, 2024

Docker Image for PR

  • tag: pr-16359-d31c6b3-1725247066

note: this image tag is only available for internal use,
please check the internal doc for more details.

Copy link
Contributor

github-actions bot commented Sep 2, 2024

Docker Image for PR

  • tag: pr-16359-d31c6b3-1725247149

note: this image tag is only available for internal use,
please check the internal doc for more details.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 2, 2024
@Dousir9 Dousir9 added this pull request to the merge queue Sep 2, 2024
@BohuTANG BohuTANG removed this pull request from the merge queue due to a manual request Sep 2, 2024
@BohuTANG BohuTANG merged commit 5fff933 into databendlabs:main Sep 2, 2024
75 of 77 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-query Area: databend query ci-benchmark Benchmark: run all test lgtm This PR has been approved by a maintainer pr-chore this PR only has small changes that no need to record, like coding styles. pr-refactor this PR changes the code base without new features or bugfix size:XXL This PR changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Inner Join Fails with OOM or Index Out of Range Despite Settings
3 participants