Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(query): fix incorrect alias of select items #16368

Merged
merged 6 commits into from
Sep 3, 2024

Conversation

sundy-li
Copy link
Member

@sundy-li sundy-li commented Sep 2, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

fixes #16367

🐳 :) select siphash('y'), siphash('Y');
┌───────────────────────────────────────────┐
│     siphash('y')    │     siphash('Y')    │
│        UInt64       │        UInt64       │
├─────────────────────┼─────────────────────┤
│ 5356863688430645057 │ 9746634682266333199 │
└───────────────────────────────────────────┘
1 row read in 0.038 sec. Processed 1 row, 1B (26.08 rows/s, 26B/s)

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Need tests in bendsql or other clients

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Sep 2, 2024
@sundy-li sundy-li requested a review from xudong963 September 2, 2024 07:21
@github-actions github-actions bot added the pr-bugfix this PR patches a bug in codebase label Sep 2, 2024
@dosubot dosubot bot added A-query Area: databend query C-bug Category: something isn't working labels Sep 2, 2024
@sundy-li sundy-li marked this pull request as draft September 2, 2024 07:59
@sundy-li sundy-li marked this pull request as ready for review September 2, 2024 13:57
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Sep 2, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 3, 2024
@BohuTANG BohuTANG merged commit d21835d into databendlabs:main Sep 3, 2024
77 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-query Area: databend query C-bug Category: something isn't working lgtm This PR has been approved by a maintainer pr-bugfix this PR patches a bug in codebase size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: literal should not display as lower case
3 participants