Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(query): refactor some codes of parquet2 #16386

Merged
merged 1 commit into from
Sep 4, 2024
Merged

refactor(query): refactor some codes of parquet2 #16386

merged 1 commit into from
Sep 4, 2024

Conversation

sundy-li
Copy link
Member

@sundy-li sundy-li commented Sep 4, 2024 •
edited by drmingdrmer
Loading

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

  1. refactor some codes of parquet2
  2. bump up logictests crate

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Sep 4, 2024
@github-actions github-actions bot added the pr-refactor this PR changes the code base without new features or bugfix label Sep 4, 2024
@dosubot dosubot bot added the A-query Area: databend query label Sep 4, 2024
@sundy-li sundy-li marked this pull request as draft September 4, 2024 07:49
@sundy-li sundy-li requested a review from b41sh September 4, 2024 11:36
@sundy-li sundy-li marked this pull request as ready for review September 4, 2024 11:36
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 4, 2024
@b41sh b41sh added this pull request to the merge queue Sep 4, 2024
@BohuTANG BohuTANG removed this pull request from the merge queue due to a manual request Sep 4, 2024
@BohuTANG BohuTANG merged commit 11a6daf into databendlabs:main Sep 4, 2024
101 checks passed
@andylokandy andylokandy mentioned this pull request Oct 15, 2024
Merged
11 tasks
@andylokandy andylokandy mentioned this pull request Oct 25, 2024
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@b41sh b41sh b41sh approved these changes

Assignees
No one assigned
Labels
A-query Area: databend query lgtm This PR has been approved by a maintainer pr-refactor this PR changes the code base without new features or bugfix size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sundy-li @b41sh @BohuTANG